Skip to content

fix(graphql): add hasUncoveredLines filter to ImpactedFilesFilters #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(graphql): add hasUncoveredLines filter to ImpactedFilesFilters #1217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions apps/codecov-api/compare/commands/compare/interactors/fetch_impacted_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,4 +137,11 @@ def execute(
else:
impacted_files = comparison_report.impacted_files

has_uncovered_lines = filters.get("has_uncovered_lines")
if has_uncovered_lines is not None:
impacted_files = [
f for f in impacted_files
if (f.misses_count > 0) == has_uncovered_lines
]

return self._apply_filters(impacted_files, comparison, filters)
1 change: 1 addition & 0 deletions apps/codecov-api/graphql_api/types/inputs/impacted_files_filters.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
input ImpactedFilesFilters {
ordering: ImpactedFilesOrdering
hasUnintendedChanges: Boolean
hasUncoveredLines: Boolean
flags: [String!]
components: [String!]
}
Expand Down
Loading