fix(worker): improve Bitbucket API error handling for diffs#1224
Open
sentry[bot] wants to merge 1 commit into
Open
fix(worker): improve Bitbucket API error handling for diffs#1224sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1224 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 1325 1325
Lines 50862 50862
Branches 1626 1626
==========================================
- Hits 46741 46740 -1
- Misses 3815 3816 +1
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue WORKER-YTS, where
TorngitServerUnreachableErrorwas being raised misleadingly when Bitbucket dropped a connection mid-stream while serving a large diff.Root Cause:
Bitbucket was reachable and returned
200 OK, but then closed the TCP connection before the full diff response body was transmitted. This resulted in anhttpx.ReadError(a type ofhttpx.NetworkError), which was then caught byshared/torngit/bitbucket.pyand re-raised as a genericTorngitServerUnreachableError. TheComputeComparisontask did not explicitly handle this specific error, leading to task failures.Changes Implemented:
apps/worker/tasks/compute_comparison.py:TorngitServerUnreachableErrorfor explicit handling.comparison_proxy.get_patch_totals()call in atry/exceptblock to catchTorngitServerUnreachableError. Upon catching, the task now logs a warning, sets the comparison state toerror, and returns gracefully with an appropriate error message.try/exceptblock forcomparison_proxy.get_impacted_files()to also catchTorngitServerUnreachableError, ensuring consistent error handling for Bitbucket API calls within the task.libs/shared/shared/torngit/bitbucket.py:_send_requestmethod to differentiate between various network errors. A specificexcept httpx.ReadErrorblock was added before the more generalhttpx.NetworkErrorcatch. This allows for a more preciseTorngitServerUnreachableErrormessage, indicating a "connection dropped mid-response" when aReadErroroccurs, providing better context for debugging.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YTS