Skip to content

fix(elm): Correctly append end-line partials in Elm processor#1225

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/elm-processor-typerror
Open

fix(elm): Correctly append end-line partials in Elm processor#1225
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/elm-processor-typerror

Conversation

@sentry

@sentry sentry Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

This PR addresses a TypeError: '<' not supported between instances of 'NoneType' and 'int' that occurred during the merging of coverage partials for Elm reports.

Root Cause:
The from_json function in apps/worker/services/report/languages/elm.py had a typo. For multi-line declarations, it incorrectly appended the end-of-span partial ([[None, ec, cov]]) to the start line (sl) instead of the end line (el). This led to two conflicting LineSession entries for the same line, one with [sc, None, cov] and another with [None, ec, cov]. When these were merged, the sorted(key=lambda p: p[0]) function attempted to compare None with an int, raising the TypeError in Python 3.

Changes Made:

  1. Corrected partial append: Changed _file.append(sl, ...) to _file.append(el, ...) on line 46 in apps/worker/services/report/languages/elm.py. This ensures the end-of-span partial is correctly associated with its respective end line.
  2. Optimized intermediate line handling: Adjusted the range for intermediate lines from range(sl, el) to range(sl + 1, el). This prevents redundant full-coverage appends to the start line, which is already handled by the initial append.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes WORKER-YTT

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.89%. Comparing base (7b60783) to head (c2aede3).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/services/report/languages/elm.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1225   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files        1325     1325           
  Lines       50862    50862           
  Branches     1626     1626           
=======================================
  Hits        46741    46741           
  Misses       3815     3815           
  Partials      306      306           
Flag Coverage Δ
workerintegration 58.56% <0.00%> (ø)
workerunit 90.37% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/services/report/languages/elm.py 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants