fix(elm): Correctly append end-line partials in Elm processor#1225
Open
sentry[bot] wants to merge 1 commit into
Open
fix(elm): Correctly append end-line partials in Elm processor#1225sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 1325 1325
Lines 50862 50862
Branches 1626 1626
=======================================
Hits 46741 46741
Misses 3815 3815
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: '<' not supported between instances of 'NoneType' and 'int'that occurred during the merging of coverage partials for Elm reports.Root Cause:
The
from_jsonfunction inapps/worker/services/report/languages/elm.pyhad a typo. For multi-line declarations, it incorrectly appended the end-of-span partial ([[None, ec, cov]]) to the start line (sl) instead of the end line (el). This led to two conflictingLineSessionentries for the same line, one with[sc, None, cov]and another with[None, ec, cov]. When these were merged, thesorted(key=lambda p: p[0])function attempted to compareNonewith anint, raising theTypeErrorin Python 3.Changes Made:
_file.append(sl, ...)to_file.append(el, ...)on line 46 inapps/worker/services/report/languages/elm.py. This ensures the end-of-span partial is correctly associated with its respective end line.rangefor intermediate lines fromrange(sl, el)torange(sl + 1, el). This prevents redundant full-coverage appends to the start line, which is already handled by the initial append.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YTT