fix(test_analytics): Resolve N+1 query in ProcessFlakesTask#1229
Open
sentry[bot] wants to merge 1 commit into
Open
fix(test_analytics): Resolve N+1 query in ProcessFlakesTask#1229sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1229 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 1325 1325
Lines 50868 50875 +7
Branches 1626 1626
=======================================
+ Hits 46744 46751 +7
Misses 3818 3818
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue within the
app.tasks.flakes.ProcessFlakesTask.Problem:
Previously, the
process_flakes_for_commitfunction would fetch all uploads for a given commit. Then, for each individual upload, it would callprocess_single_upload, which in turn executed a separate database query to retrieveTestrunobjects associated with that specific upload. This led to an N+1 query pattern, where N is the number of uploads for a commit, causing significant database overhead and slower task execution.Solution:
get_testrunsfunction was refactored intoget_testruns_for_uploads. This new function now accepts a list ofupload_idsand fetches all relevantTestrunobjects for all these uploads in a single batched query. The results are then grouped byupload_idfor efficient access.process_single_upload: Theprocess_single_uploadfunction was updated to accept the pre-fetched list ofTestrunobjects directly, eliminating its internal database query.bulk_update: Instead of performingTestrun.objects.bulk_updatefor each upload within the loop, all modifiedTestrunobjects are now collected, and a singlebulk_updateoperation is performed after processing all uploads for the commit.Impact:
This change significantly reduces the number of database queries from
1 + N(where N is the number of uploads) to a fixed2queries (one for uploads, one for all associated testruns), drastically improving the performance and reducing the database load forProcessFlakesTaskexecutions, especially for commits with a large number of test result uploads.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YTZ