Skip to content

fix(test_analytics): Resolve N+1 query in ProcessFlakesTask#1229

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/ta-flakes-n-plus-1-cMQbVa
Open

fix(test_analytics): Resolve N+1 query in ProcessFlakesTask#1229
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/ta-flakes-n-plus-1-cMQbVa

Conversation

@sentry

@sentry sentry Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

This PR addresses an N+1 query performance issue within the app.tasks.flakes.ProcessFlakesTask.

Problem:
Previously, the process_flakes_for_commit function would fetch all uploads for a given commit. Then, for each individual upload, it would call process_single_upload, which in turn executed a separate database query to retrieve Testrun objects associated with that specific upload. This led to an N+1 query pattern, where N is the number of uploads for a commit, causing significant database overhead and slower task execution.

Solution:

  1. Batch Fetching of Testruns: The get_testruns function was refactored into get_testruns_for_uploads. This new function now accepts a list of upload_ids and fetches all relevant Testrun objects for all these uploads in a single batched query. The results are then grouped by upload_id for efficient access.
  2. Updated process_single_upload: The process_single_upload function was updated to accept the pre-fetched list of Testrun objects directly, eliminating its internal database query.
  3. Consolidated bulk_update: Instead of performing Testrun.objects.bulk_update for each upload within the loop, all modified Testrun objects are now collected, and a single bulk_update operation is performed after processing all uploads for the commit.

Impact:
This change significantly reduces the number of database queries from 1 + N (where N is the number of uploads) to a fixed 2 queries (one for uploads, one for all associated testruns), drastically improving the performance and reducing the database load for ProcessFlakesTask executions, especially for commits with a large number of test result uploads.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes WORKER-YTZ

@codecov-notifications

codecov-notifications Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (e682d07) to head (634d534).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1229   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files        1325     1325           
  Lines       50868    50875    +7     
  Branches     1626     1626           
=======================================
+ Hits        46744    46751    +7     
  Misses       3818     3818           
  Partials      306      306           
Flag Coverage Δ
workerintegration 58.54% <7.14%> (-0.03%) ⬇️
workerunit 90.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants