Skip to content

fix(worker): eliminate N+1 query in ProcessFlakesTask#1231

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/process-flakes-n1-query-Ajsjb1
Open

fix(worker): eliminate N+1 query in ProcessFlakesTask#1231
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/process-flakes-n1-query-Ajsjb1

Conversation

@sentry

@sentry sentry Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This PR addresses an N+1 query issue in app.tasks.flakes.ProcessFlakesTask, specifically within the process_flakes_for_commit function in apps/worker/services/test_analytics/ta_process_flakes.py.

Problem:
Previously, when process_flakes_for_commit was executed for a commit that had multiple associated uploads, it would iterate through each upload and call process_single_upload for each one. Each call to process_single_upload would then perform a separate SELECT query to fetch testruns and a separate bulk_update to modify their outcomes. This led to an N+1 query pattern, where N is the number of uploads for a given commit, resulting in N SELECTs and N UPDATEs on the ta_timeseries_testrun table.

Solution:
To resolve this, the logic has been refactored to batch these database operations:

  1. A new function, get_testruns_for_uploads, was introduced to fetch all relevant testruns for all uploads associated with a commit in a single SELECT query using upload_id__in.
  2. A new function, process_all_uploads, was created to process all these fetched testruns in a single pass, applying the flake detection logic.
  3. The process_flakes_for_commit function now calls process_all_uploads once, which then performs a single bulk_update on all modified testruns.

This change reduces the database interactions from N SELECTs + N UPDATEs to a single SELECT + a single UPDATE, significantly improving performance for commits with multiple uploads.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes WORKER-YV1

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.86%. Comparing base (e682d07) to head (fa19945).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1231      +/-   ##
==========================================
- Coverage   91.89%   91.86%   -0.03%     
==========================================
  Files        1325     1325              
  Lines       50868    50884      +16     
  Branches     1626     1626              
==========================================
+ Hits        46744    46745       +1     
- Misses       3818     3833      +15     
  Partials      306      306              
Flag Coverage Δ
workerintegration 58.52% <15.78%> (-0.04%) ⬇️
workerunit 90.29% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

codecov-notifications Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants