fix(worker): eliminate N+1 query in ProcessFlakesTask#1231
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1231 +/- ##
==========================================
- Coverage 91.89% 91.86% -0.03%
==========================================
Files 1325 1325
Lines 50868 50884 +16
Branches 1626 1626
==========================================
+ Hits 46744 46745 +1
- Misses 3818 3833 +15
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query issue in
app.tasks.flakes.ProcessFlakesTask, specifically within theprocess_flakes_for_commitfunction inapps/worker/services/test_analytics/ta_process_flakes.py.Problem:
Previously, when
process_flakes_for_commitwas executed for a commit that had multiple associated uploads, it would iterate through each upload and callprocess_single_uploadfor each one. Each call toprocess_single_uploadwould then perform a separateSELECTquery to fetch testruns and a separatebulk_updateto modify their outcomes. This led to an N+1 query pattern, where N is the number of uploads for a given commit, resulting in N SELECTs and N UPDATEs on theta_timeseries_testruntable.Solution:
To resolve this, the logic has been refactored to batch these database operations:
get_testruns_for_uploads, was introduced to fetch all relevant testruns for all uploads associated with a commit in a singleSELECTquery usingupload_id__in.process_all_uploads, was created to process all these fetched testruns in a single pass, applying the flake detection logic.process_flakes_for_commitfunction now callsprocess_all_uploadsonce, which then performs a singlebulk_updateon all modified testruns.This change reduces the database interactions from N SELECTs + N UPDATEs to a single SELECT + a single UPDATE, significantly improving performance for commits with multiple uploads.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YV1