Skip to content

fix(upload): gracefully handle Bitbucket unreachable during webhook setup#1236

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/upload-bitbucket-webhook-timeout
Open

fix(upload): gracefully handle Bitbucket unreachable during webhook setup#1236
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/upload-bitbucket-webhook-timeout

Conversation

@sentry

@sentry sentry Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This PR addresses issue WORKER-YV6, where the Upload task would fail with a TorngitServerUnreachableError when attempting to set up a Bitbucket webhook.

The root cause was identified as a httpx.ConnectTimeout (wrapped as TorngitServerUnreachableError) occurring during the POST request to Bitbucket's API for webhook registration. This error was not being caught by the existing except TorngitClientError block in possibly_setup_webhooks because TorngitServerUnreachableError inherits from TorngitServerFailureError, not TorngitClientError.

Since webhook registration is a non-critical side-effect of the upload process, a transient network issue preventing its completion should not cause the entire upload task to fail. This fix modifies the possibly_setup_webhooks function to explicitly catch TorngitServerUnreachableError. When caught, it logs a warning with the exception details and allows the upload task to continue processing, ensuring that coverage reports are not blocked by temporary API unreachability.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes WORKER-YV6

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.88%. Comparing base (e682d07) to head (d2f04f6).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/tasks/upload.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
- Coverage   91.89%   91.88%   -0.01%     
==========================================
  Files        1325     1325              
  Lines       50868    50870       +2     
  Branches     1626     1626              
==========================================
  Hits        46744    46744              
- Misses       3818     3820       +2     
  Partials      306      306              
Flag Coverage Δ
workerintegration 58.55% <33.33%> (-0.01%) ⬇️
workerunit 90.36% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

codecov-notifications Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/tasks/upload.py 33.33% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants