Skip to content

fix(worker): Resolve N+1 query in ProcessFlakesTask#1237

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-process-flakes-n1-olyWJt
Open

fix(worker): Resolve N+1 query in ProcessFlakesTask#1237
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-process-flakes-n1-olyWJt

Conversation

@sentry

@sentry sentry Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This PR addresses an N+1 query issue identified in the app.tasks.flakes.ProcessFlakesTask, specifically within the services.test_analytics.ta_process_flakes.py module.

Problem:

  1. Testrun Fetching: The process_flakes_for_commit function iterated over ReportSession objects (uploads), and for each upload, it called process_single_upload. Inside process_single_upload, get_testruns(upload) was called, resulting in a separate database query for testruns for each upload. This led to N+1 queries where N is the number of uploads for a given commit.
  2. Flake Expiration Saves: When a flake met its expiration criteria in handle_pass, it would immediately call .save() on the individual Flake object, leading to multiple individual update queries if many flakes expired in a single run.

Solution:

  1. Batch Testrun Fetching: A new helper function, get_testruns_for_uploads, was introduced. This function now fetches all relevant testruns for all uploads associated with a commit in a single batched query using upload_id__in. The results are then grouped by upload_id and passed to process_single_upload.
  2. Batch Flake Updates: The handle_pass function no longer calls .save() directly. Instead, expiring Flake objects are collected into a list (expired_flakes). After all uploads and testruns have been processed, a single Flake.objects.bulk_update is performed on all collected expired_flakes.

These changes significantly reduce the number of database queries, improving the performance and efficiency of the ProcessFlakesTask.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes WORKER-YV7

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (e682d07) to head (b1814fe).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1237   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files        1325     1325           
  Lines       50868    50874    +6     
  Branches     1626     1626           
=======================================
+ Hits        46744    46750    +6     
  Misses       3818     3818           
  Partials      306      306           
Flag Coverage Δ
workerintegration 58.54% <13.33%> (-0.03%) ⬇️
workerunit 90.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants