fix(worker): Resolve N+1 query in ProcessFlakesTask#1237
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 1325 1325
Lines 50868 50874 +6
Branches 1626 1626
=======================================
+ Hits 46744 46750 +6
Misses 3818 3818
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query issue identified in the
app.tasks.flakes.ProcessFlakesTask, specifically within theservices.test_analytics.ta_process_flakes.pymodule.Problem:
process_flakes_for_commitfunction iterated overReportSessionobjects (uploads), and for each upload, it calledprocess_single_upload. Insideprocess_single_upload,get_testruns(upload)was called, resulting in a separate database query for testruns for each upload. This led to N+1 queries where N is the number of uploads for a given commit.handle_pass, it would immediately call.save()on the individualFlakeobject, leading to multiple individual update queries if many flakes expired in a single run.Solution:
get_testruns_for_uploads, was introduced. This function now fetches all relevant testruns for all uploads associated with a commit in a single batched query usingupload_id__in. The results are then grouped byupload_idand passed toprocess_single_upload.handle_passfunction no longer calls.save()directly. Instead, expiringFlakeobjects are collected into a list (expired_flakes). After all uploads and testruns have been processed, a singleFlake.objects.bulk_updateis performed on all collectedexpired_flakes.These changes significantly reduce the number of database queries, improving the performance and efficiency of the
ProcessFlakesTask.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YV7