perf(worker): Optimize flake processing N+1 query#1238
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1238 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 1325 1325
Lines 50868 50871 +3
Branches 1626 1626
=======================================
+ Hits 46744 46747 +3
Misses 3818 3818
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an N+1 query issue within the
app.tasks.flakes.ProcessFlakesTaskby optimizing howTestrunobjects are fetched and updated.Problem:
Previously, the
process_flakes_for_commitfunction iterated over uploads, and for each upload, it would callget_testruns, resulting in a separate database query forTestrunobjects per upload. Additionally,Testrun.objects.bulk_updatewas called inside the loop, leading to multiple update queries.Solution:
get_testrunsfunction has been refactored to accept a list ofupload_idsand now usesupload_id__into fetch all relevantTestrunobjects in a single database query.process_flakes_for_commit, after fetching allTestrunobjects, they are grouped byupload_idin memory.process_single_uploadnow receives the pre-fetched and groupedTestrunobjects directly, eliminating the need for per-upload database queries.Testrunobjects are accumulated, andTestrun.objects.bulk_updateis now called only once after all uploads have been processed.This change significantly reduces the number of database queries and improves the performance of the
ProcessFlakesTask, especially for commits with many test result uploads.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YV8