Skip to content

fix(worker): optimize ProcessFlakesTask N+1 query#1239

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-process-flakes-n-plus-1-FVYYRq
Open

fix(worker): optimize ProcessFlakesTask N+1 query#1239
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-process-flakes-n-plus-1-FVYYRq

Conversation

@sentry

@sentry sentry Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

The ProcessFlakesTask was suffering from an N+1 query issue in apps/worker/services/test_analytics/ta_process_flakes.py.
Specifically, the process_flakes_for_commit function iterated over uploads, and for each upload, it called process_single_upload, which in turn called get_testruns(upload). This resulted in a separate database query for testruns for each upload, leading to N+1 queries.

This change refactors the flake processing to:

  1. Introduce get_all_testruns to fetch all relevant testruns for all uploads in a single database query.
  2. Modify process_single_upload to accept a pre-fetched list of testruns, eliminating its internal database query.
  3. Accumulate all modified testruns and perform a single Testrun.objects.bulk_update after processing all uploads, instead of multiple individual updates.

This significantly reduces the number of database queries, improving the performance of the ProcessFlakesTask.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes WORKER-YV9

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (e682d07) to head (d6588f3).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1239      +/-   ##
==========================================
- Coverage   91.89%   91.89%   -0.01%     
==========================================
  Files        1325     1325              
  Lines       50868    50878      +10     
  Branches     1626     1626              
==========================================
+ Hits        46744    46752       +8     
- Misses       3818     3820       +2     
  Partials      306      306              
Flag Coverage Δ
workerintegration 58.53% <7.14%> (-0.04%) ⬇️
workerunit 90.36% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

codecov-notifications Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants