fix(worker): Optimize N+1 queries in ProcessFlakesTask#1240
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 1325 1325
Lines 50868 50878 +10
Branches 1626 1626
==========================================
+ Hits 46744 46752 +8
- Misses 3818 3820 +2
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query pattern identified in the
app.tasks.flakes.ProcessFlakesTask, specifically within theservices.test_analytics.ta_process_flakesmodule.Problem:
Previously,
process_flakes_for_commitwould iterate through eachReportSession(upload) and then callget_testruns(upload), which executed a separate database query to fetch testruns for that specific upload. This resulted in N+1 queries, where N is the number of uploads for a given commit.Additionally, when a flake expired (reached 30 recent passes),
handle_passwould callflake.save()individually, leading to further N+1 queries if many flakes expired in a single run.Solution:
get_testruns_for_uploadsto fetch all relevantTestrunobjects for all uploads associated with a commit in a single batched query. Theprocess_single_uploadfunction was updated to receive these pre-fetched testruns, eliminating the per-upload database calls.handle_passto no longer callflake.save()directly. Instead, expiredFlakeobjects are collected into a list (expired_flakes), and a singleFlake.objects.bulk_update()is performed at the end ofprocess_flakes_for_committo persist these changes efficiently.These changes significantly reduce the database load and improve the performance of the
ProcessFlakesTaskby converting multiple individual queries into batched operations.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YVA