Skip to content

fix(worker): Optimize N+1 queries in ProcessFlakesTask#1240

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/optimize-process-flakes-task
Open

fix(worker): Optimize N+1 queries in ProcessFlakesTask#1240
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/optimize-process-flakes-task

Conversation

@sentry

@sentry sentry Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This PR addresses an N+1 query pattern identified in the app.tasks.flakes.ProcessFlakesTask, specifically within the services.test_analytics.ta_process_flakes module.

Problem:
Previously, process_flakes_for_commit would iterate through each ReportSession (upload) and then call get_testruns(upload), which executed a separate database query to fetch testruns for that specific upload. This resulted in N+1 queries, where N is the number of uploads for a given commit.
Additionally, when a flake expired (reached 30 recent passes), handle_pass would call flake.save() individually, leading to further N+1 queries if many flakes expired in a single run.

Solution:

  1. Batch Testrun Fetching: Introduced get_testruns_for_uploads to fetch all relevant Testrun objects for all uploads associated with a commit in a single batched query. The process_single_upload function was updated to receive these pre-fetched testruns, eliminating the per-upload database calls.
  2. Bulk Update for Expired Flakes: Modified handle_pass to no longer call flake.save() directly. Instead, expired Flake objects are collected into a list (expired_flakes), and a single Flake.objects.bulk_update() is performed at the end of process_flakes_for_commit to persist these changes efficiently.

These changes significantly reduce the database load and improve the performance of the ProcessFlakesTask by converting multiple individual queries into batched operations.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes WORKER-YVA

@codecov-notifications

codecov-notifications Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (e682d07) to head (25de8a6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
- Coverage   91.89%   91.89%   -0.01%     
==========================================
  Files        1325     1325              
  Lines       50868    50878      +10     
  Branches     1626     1626              
==========================================
+ Hits        46744    46752       +8     
- Misses       3818     3820       +2     
  Partials      306      306              
Flag Coverage Δ
workerintegration 58.53% <12.50%> (-0.04%) ⬇️
workerunit 90.36% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants