remove FeatureExposure and SimpleMetric models#58
Merged
matt-codecov merged 2 commits intomainfrom Apr 28, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 93.96% 93.96%
=======================================
Files 1213 1214 +1
Lines 45963 45935 -28
Branches 1453 1451 -2
=======================================
- Hits 43187 43163 -24
+ Misses 2471 2467 -4
Partials 305 305
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #58 will not alter performanceComparing Summary
|
Swatinem
approved these changes
Apr 28, 2025
matt-codecov
force-pushed
the
shared/matt/remove-sql-metrics
branch
from
4eccdf2 to
fd8baaa
Compare
This was referenced Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(migrated from codecov/shared#571)
these were never really fleshed out so i am deleting them
if we want to re-add them in the future, we need to do it with partitioning or something
this PR should be merged at the end of the day in coordination with infra. as a followup, the
pg_telemetryapp can be fully deleted, but for now it needs to still exist so that the migration to delete the table will runLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.