Skip to content

perf(worker): Eagerly load related objects for processed reports#858

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/eager-load-processed-reports
Open

perf(worker): Eagerly load related objects for processed reports#858
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/eager-load-processed-reports

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry Bot commented Apr 19, 2026

Fixes WORKER-Y8R. The issue was that: ReportSession objects fetched without eager loading related report, commit, and repository objects, causing N additional queries to codecov_replica.

  • Added .select_related("report", "report__commit", "report__commit__repository") to the fetch_processed_reports queryset.
  • This change optimizes database queries by eagerly loading related objects, reducing potential N+1 query issues.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13533917

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk performance change that only adjusts ORM query loading to avoid N+1 queries when iterating processed ReportSessions. Main risk is unexpected query shape/memory increase if many sessions are fetched at once.

Overview
Optimizes test analytics flake processing by eagerly loading ReportSession relations via .select_related("report", "report__commit", "report__commit__repository") in get_relevant_uploads.

This reduces extra database round-trips (N+1) when accessing related report/commit/repository data during upload processing.

Reviewed by Cursor Bugbot for commit d1c9cdf. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry Bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (0ad8a0c) to head (d1c9cdf).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1307     1307           
  Lines       48017    48017           
  Branches     1636     1636           
=======================================
  Hits        44299    44299           
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.54% <ø> (ø)
workerunit 90.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants