Skip to content

perf(worker): Batch testrun queries for flake processing#862

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-flake-processing
Open

perf(worker): Batch testrun queries for flake processing#862
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-flake-processing

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry Bot commented Apr 19, 2026

Fixes WORKER-Y8W. The issue was that: Iterating uploads and fetching testruns per upload causes N+1 queries, plus additional N queries for bulk updates.

  • Refactored flake processing to fetch all relevant testruns for a commit in a single query, rather than per upload.
  • Removed the process_single_upload function, integrating its logic directly into process_flakes_for_commit.
  • Updated get_testruns to accept a list of upload IDs, enabling batch retrieval of testruns.
  • Improved performance by reducing the number of database queries during flake processing.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13537607

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk performance refactor that changes query shape and batching for flake detection; main risk is missing/extra Testrun selection if upload_ids batching behaves differently than per-upload filtering.

Overview
Flake processing for a commit is refactored to batch-fetch all relevant Testruns in one query using upload_id__in, instead of iterating uploads and querying/updating per upload.

This removes process_single_upload, updates get_testruns to accept a list of upload IDs, and performs a single bulk_update of Testrun.outcome after processing.

Reviewed by Cursor Bugbot for commit b79b2e2. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry Bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (0ad8a0c) to head (b79b2e2).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
- Coverage   92.25%   92.25%   -0.01%     
==========================================
  Files        1307     1307              
  Lines       48017    48011       -6     
  Branches     1636     1636              
==========================================
- Hits        44299    44293       -6     
  Misses       3407     3407              
  Partials      311      311              
Flag Coverage Δ
workerintegration 58.55% <6.66%> (+<0.01%) ⬆️
workerunit 90.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants