perf(worker): Optimize flake processing by batching testruns#863
Open
sentry[bot] wants to merge 1 commit intomainfrom
Open
perf(worker): Optimize flake processing by batching testruns#863sentry[bot] wants to merge 1 commit intomainfrom
sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #863 +/- ##
==========================================
- Coverage 92.25% 92.25% -0.01%
==========================================
Files 1307 1307
Lines 48017 48012 -5
Branches 1636 1636
==========================================
- Hits 44299 44294 -5
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-Y8X. The issue was that:
process_single_uploadqueriesTestruntable for eachReportSessionin a loop, causing N+1 queries.get_testrunsto accept a list ofReportSessionobjects, enabling it to fetch testruns for multiple uploads simultaneously.process_single_uploadfunction, consolidating its logic.process_flakes_for_committo fetch all relevant testruns for a commit's uploads in a single query.bulk_updateat the end.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13544443
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Medium Risk
Moderate risk because it refactors flake detection to process all uploads’
Testruns in one batch, which could subtly change ordering/side effects (e.g., when outcomes are updated) and impacts DB write patterns.Overview
Optimizes flake processing by removing per-upload
Testrunqueries.get_testrunsnow accepts multipleReportSessions and fetches all recent testruns viaupload_id__in, eliminating the N+1 loop.process_flakes_for_commitis refactored to load all relevant uploads and testruns up front, apply the existing pass/fail flake logic across the combined stream, and perform a singlebulk_updateof updated testrun outcomes at the end; theprocess_single_uploadhelper is removed.Reviewed by Cursor Bugbot for commit 87b9bc5. Bugbot is set up for automated code reviews on this repo. Configure here.