Skip to content

perf(worker): Optimize flake processing by batching testruns#863

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-flake-processing-bblMHl
Open

perf(worker): Optimize flake processing by batching testruns#863
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-flake-processing-bblMHl

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry Bot commented Apr 19, 2026

Fixes WORKER-Y8X. The issue was that: process_single_upload queries Testrun table for each ReportSession in a loop, causing N+1 queries.

  • Modified get_testruns to accept a list of ReportSession objects, enabling it to fetch testruns for multiple uploads simultaneously.
  • Removed the process_single_upload function, consolidating its logic.
  • Refactored process_flakes_for_commit to fetch all relevant testruns for a commit's uploads in a single query.
  • Streamlined flake detection logic to iterate over all fetched testruns and perform a single bulk_update at the end.
  • Improved performance by reducing database interactions and batching operations.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13544443

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Medium Risk
Moderate risk because it refactors flake detection to process all uploads’ Testruns in one batch, which could subtly change ordering/side effects (e.g., when outcomes are updated) and impacts DB write patterns.

Overview
Optimizes flake processing by removing per-upload Testrun queries. get_testruns now accepts multiple ReportSessions and fetches all recent testruns via upload_id__in, eliminating the N+1 loop.

process_flakes_for_commit is refactored to load all relevant uploads and testruns up front, apply the existing pass/fail flake logic across the combined stream, and perform a single bulk_update of updated testrun outcomes at the end; the process_single_upload helper is removed.

Reviewed by Cursor Bugbot for commit 87b9bc5. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry Bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (0ad8a0c) to head (87b9bc5).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   92.25%   92.25%   -0.01%     
==========================================
  Files        1307     1307              
  Lines       48017    48012       -5     
  Branches     1636     1636              
==========================================
- Hits        44299    44294       -5     
  Misses       3407     3407              
  Partials      311      311              
Flag Coverage Δ
workerintegration 58.55% <6.25%> (+<0.01%) ⬆️
workerunit 90.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants