Skip to content

perf(worker): Eagerly load repository author in flake processing#865

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/ta-eager-load-author
Open

perf(worker): Eagerly load repository author in flake processing#865
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/ta-eager-load-author

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry Bot commented Apr 20, 2026

Fixes WORKER-Y8Z. The issue was that: get_relevant_uploads lacks select_related for foreign keys, causing N+1 queries when iterating ReportSession objects.

  • Added .select_related("report__commit__repository__author") to the _fetch_processed_reports query.
  • Optimizes database access by eagerly loading the repository author when fetching processed reports for flake analysis.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13557176

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk performance tweak to a Django queryset; behavior should be unchanged aside from fewer DB queries, though it slightly increases per-query join/row size.

Overview
Reduces N+1 database queries in test flake processing by updating get_relevant_uploads() to eagerly load the related repository author via select_related("report__commit__repository__author") when fetching processed ReportSessions for a commit.

Reviewed by Cursor Bugbot for commit cdb99d8. Bugbot is set up for automated code reviews on this repo. Configure here.

state__in=["processed"],
)
).select_related("report__commit__repository__author")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The get_relevant_uploads query includes an unnecessary .select_related() for the author field, which is never accessed in the flake processing logic, causing a needless database JOIN.
Severity: LOW

Suggested Fix

Remove report__commit__repository__author from the .select_related() call within the get_relevant_uploads function, as the author field is not used by the caller.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: apps/worker/services/test_analytics/ta_process_flakes.py#L28

Potential issue: The query in `get_relevant_uploads` was modified to include
`.select_related("report__commit__repository__author")` to pre-fetch the repository's
author. However, the subsequent processing logic in `process_single_upload` never
accesses the `author` field. This results in an unnecessary JOIN operation on the
database every time flakes are processed for a repository. While the performance impact
is minor for a background task, it introduces needless database load.

Did we get this right? 👍 / 👎 to inform future reviews.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (0ad8a0c) to head (cdb99d8).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #865   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1307     1307           
  Lines       48017    48017           
  Branches     1636     1636           
=======================================
  Hits        44299    44299           
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.54% <ø> (ø)
workerunit 90.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants