perf(worker): Batch fetch testruns for flake processing

[sentry]

Fixes WORKER-Y99. The issue was that: ProcessFlakesTask executes N+1 queries by fetching testruns individually per upload and saving flakes one-by-one when expiring.

• Refactored get_testruns into get_testruns_for_uploads to fetch testruns for multiple uploads simultaneously.
• Modified process_flakes_for_commit to fetch all relevant testruns in a single query, grouped by upload ID.
• Updated process_single_upload to accept pre-fetched testruns, eliminating redundant database calls within the loop.
• Improved performance of flake processing by reducing the number of database queries.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13586471

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

---

Note

Medium Risk
Reduces DB query count by changing how Testruns are fetched and passed through flake processing; while behavior should be equivalent, any mismatch in grouping or filtering by upload could affect flake/outcome updates.

Overview
Flake processing now batch-loads Testruns per commit instead of querying per upload. get_testruns is replaced with get_testruns_for_uploads, which fetches all recent testruns for a set of upload IDs in one query and groups them by upload_id.

process_flakes_for_commit precomputes testruns_by_upload and passes the pre-fetched list into process_single_upload, removing the N+1 query pattern during per-upload processing.

^{Reviewed by Cursor Bugbot for commit 4373f12. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4373f12. Configure here.}

[cursor]

Unused upload parameter in process_single_upload

Low Severity

The upload parameter in process_single_upload is no longer used anywhere in the function body. It was previously needed to call get_testruns(upload), but now that testruns are pre-fetched and passed directly, upload serves no purpose. This dead parameter adds confusion for future maintainers.

 

^{Reviewed by Cursor Bugbot for commit 4373f12. Configure here.}

[sentry]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (0ad8a0c) to head (4373f12).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #876   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1307     1307           
  Lines       48017    48023    +6     
  Branches     1636     1636           
=======================================
+ Hits        44299    44305    +6     
  Misses       3407     3407           
  Partials      311      311           

Flag	Coverage Δ
workerintegration	58.53% <16.66%> (-0.02%)	⬇️
workerunit	90.39% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codecov-notifications]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!