Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Commit 6e3bd8b

Browse files
authored
Bundle Analysis: Remove logging noise from retries (#1186)
1 parent e932541 commit 6e3bd8b

1 file changed

Lines changed: 4 additions & 13 deletions

File tree

tasks/bundle_analysis_processor.py

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
from celery.exceptions import CeleryError, SoftTimeLimitExceeded
55
from shared.reports.enums import UploadState
66
from shared.yaml import UserYaml
7-
from sqlalchemy.exc import SQLAlchemyError
87

98
from app import celery_app
109
from database.enums import ReportType
@@ -195,18 +194,10 @@ def process_impl_within_lock(
195194
result.update_upload(carriedforward=carriedforward)
196195

197196
processing_results.append(result.as_dict())
198-
except (CeleryError, SoftTimeLimitExceeded, SQLAlchemyError):
199-
log.exception(
200-
"Unable to process bundle analysis upload",
201-
extra=dict(
202-
repoid=repoid,
203-
commit=commitid,
204-
commit_yaml=commit_yaml,
205-
params=params,
206-
upload_id=upload.id_,
207-
parent_task=self.request.parent_id,
208-
),
209-
)
197+
except (CeleryError, SoftTimeLimitExceeded):
198+
# This generally happens when the task needs to be retried because we attempt to access
199+
# the upload before it is saved to GCS. Anecdotally, it takes around 30s for it to be
200+
# saved, but if the BA processor runs before that we will error and need to retry.
210201
raise
211202
except Exception:
212203
log.exception(

0 commit comments

Comments
 (0)