Remove get_changes_using_rust usage (#1164)

Author: Swatinem

services/comparison/__init__.py

@@ -4,7 +4,7 @@
 
 import sentry_sdk
 from asgiref.sync import async_to_sync
-from shared.reports.changes import get_changes_using_rust, run_comparison_using_rust
+from shared.reports.changes import run_comparison_using_rust
 from shared.reports.types import Change, ReportTotals
 from shared.torngit.base import TorngitBaseAdapter
 from shared.torngit.exceptions import TorngitClientGeneralError
@@ -169,31 +169,6 @@ def get_changes(self) -> list[Change] | None:
                 self.comparison.head.report,
                 diff,
             )
-            if (
-                self._changes
-                and self.comparison.project_coverage_base.report is not None
-                and self.comparison.head.report is not None
-                and self.comparison.project_coverage_base.report.rust_report is not None
-                and self.comparison.head.report.rust_report is not None
-            ):
-                rust_changes = get_changes_using_rust(
-                    self.comparison.project_coverage_base.report,
-                    self.comparison.head.report,
-                    diff,
-                )
-                original_paths = set([c.path for c in self._changes])
-                new_paths = set([c.path for c in rust_changes])
-                if original_paths != new_paths:
-                    only_on_new = sorted(new_paths - original_paths)
-                    only_on_original = sorted(original_paths - new_paths)
-                    log.info(
-                        "There are differences between python changes and rust changes",
-                        extra=dict(
-                            only_on_new=only_on_new[:100],
-                            only_on_original=only_on_original[:100],
-                            repoid=self.head.commit.repoid,
-                        ),
-                    )
 
         return self._changes
 

services/notification/tests/unit/test_comparison.py

@@ -1,5 +1,3 @@
-from shared.reports.types import Change
-
 from services.comparison import ComparisonProxy, FilteredComparison
 
 
@@ -14,18 +12,3 @@ def test_get_existing_statuses(self, mocker):
         assert isinstance(filtered_comparison, FilteredComparison)
         res = filtered_comparison.get_existing_statuses()
         assert res == mocked_get_existing_statuses.return_value
-
-    def test_get_changes_rust_vs_python(self, mocker):
-        mocker.patch.object(ComparisonProxy, "get_diff")
-        mocker.patch(
-            "services.comparison.get_changes",
-            return_value=[Change(path="apple"), Change(path="pear")],
-        )
-        mocker.patch(
-            "services.comparison.get_changes_using_rust",
-            return_value=[Change(path="banana"), Change(path="pear")],
-        )
-        comparison = ComparisonProxy(mocker.MagicMock())
-        res = comparison.get_changes()
-        expected_result = [Change(path="apple"), Change(path="pear")]
-        assert expected_result == res