remove SQL metrics from worker tasks

Author: matt-codecov

helpers/telemetry.py

@@ -36,7 +36,6 @@
     ReportExpiredException,
     RepositoryWithoutValidBotError,
 )
-from helpers.telemetry import log_simple_metric
 from rollouts import CARRYFORWARD_BASE_SEARCH_RANGE_BY_OWNER
 from services.archive import ArchiveService
 from services.processing.metrics import (
@@ -441,7 +440,6 @@ def create_new_report_for_commit(self, commit: Commit) -> Report:
                 "Could not find parent for possible carryforward",
                 extra=dict(commit=commit.commitid, repoid=commit.repoid),
             )
-            log_simple_metric("worker_service_report_carryforward_base_not_found", 1)
             return Report()
 
         parent_report = self.get_existing_report_for_commit(parent_commit)
@@ -498,7 +496,6 @@ def create_new_report_for_commit(self, commit: Commit) -> Report:
         self._possibly_shift_carryforward_report(
             carryforward_report, parent_commit, commit
         )
-        log_simple_metric("worker_service_report_carryforward_success", 1)
         return carryforward_report
 
     @sentry_sdk.trace

helpers/tests/unit/test_telemetry.py

@@ -33,7 +33,6 @@
 from helpers.exceptions import NoConfiguredAppsAvailable, RepositoryWithoutValidBotError
 from helpers.log_context import LogContext, set_log_context
 from helpers.save_commit_error import save_commit_error
-from helpers.telemetry import TimeseriesTimer, log_simple_metric
 from services.repository import get_repo_provider_service
 
 log = logging.getLogger("worker")
@@ -300,9 +299,8 @@ def run(self, *args, **kwargs):
             self._emit_queue_metrics()
 
             try:
-                with TimeseriesTimer(f"{self.metrics_prefix}.core_runtime", sync=True):
-                    with self.task_core_runtime.time():  # Timer isn't tested
-                        return self.run_impl(db_session, *args, **kwargs)
+                with self.task_core_runtime.time():  # Timer isn't tested
+                    return self.run_impl(db_session, *args, **kwargs)
             except (DataError, IntegrityError):
                 log.exception(
                     "Errors related to the constraints of database happened",
@@ -367,13 +365,11 @@ def wrap_up_dbsession(self, db_session):
     def on_retry(self, exc, task_id, args, kwargs, einfo):
         res = super().on_retry(exc, task_id, args, kwargs, einfo)
         self.task_retry_counter.inc()
-        log_simple_metric(f"{self.metrics_prefix}.retry", 1.0)
         return res
 
     def on_success(self, retval, task_id, args, kwargs):
         res = super().on_success(retval, task_id, args, kwargs)
         self.task_success_counter.inc()
-        log_simple_metric(f"{self.metrics_prefix}.success", 1.0)
         return res
 
     def on_failure(self, exc, task_id, args, kwargs, einfo):
@@ -382,7 +378,6 @@ def on_failure(self, exc, task_id, args, kwargs, einfo):
         """
         res = super().on_failure(exc, task_id, args, kwargs, einfo)
         self.task_failure_counter.inc()
-        log_simple_metric(f"{self.metrics_prefix}.failure", 1.0)
 
         if UploadFlow.has_begun():
             UploadFlow.log(UploadFlow.CELERY_FAILURE)

services/report/__init__.py

@@ -16,7 +16,6 @@
 from database.models.staticanalysis import StaticAnalysisSuite
 from helpers.labels import get_all_report_labels, get_labels_per_session
 from helpers.metrics import metrics
-from helpers.telemetry import log_simple_metric
 from services.report import Report, ReportService
 from services.report.report_builder import SpecialLabelsEnum
 from services.repository import get_repo_provider_service
@@ -431,11 +430,6 @@ def calculate_final_result(
                 commit=commit_sha,
             ),
         )
-        log_simple_metric("label_analysis.tests_saved_count", len(all_report_labels))
-        log_simple_metric(
-            "label_analysis.requests_with_requested_labels",
-            float(requested_labels is not None),
-        )
         if requested_labels is not None:
             requested_labels = set(requested_labels)
             ans = {
@@ -446,22 +440,7 @@ def calculate_final_result(
                 "absent_labels": sorted(requested_labels - all_report_labels),
                 "global_level_labels": sorted(global_level_labels & requested_labels),
             }
-            log_simple_metric(
-                "label_analysis.requested_labels_count", len(requested_labels)
-            )
-            log_simple_metric(
-                "label_analysis.tests_to_run_count",
-                len(
-                    ans["present_diff_labels"]
-                    + ans["global_level_labels"]
-                    + ans["absent_labels"]
-                ),
-            )
             return ans
-        log_simple_metric(
-            "label_analysis.tests_to_run_count",
-            len(executable_lines_labels | global_level_labels),
-        )
         return {
             "present_report_labels": sorted(all_report_labels),
             "present_diff_labels": sorted(executable_lines_labels),

tasks/base.py

@@ -11,7 +11,6 @@
     StaticAnalysisSuite,
     StaticAnalysisSuiteFilepath,
 )
-from helpers.telemetry import log_simple_metric
 from services.archive import ArchiveService
 from tasks.base import BaseCodecovTask
 
@@ -65,8 +64,6 @@ def run_impl(
                 )
 
         db_session.commit()
-        log_simple_metric("static_analysis.data_sent_for_commit", float(True))
-        log_simple_metric("static_analysis.files_changed", changed_count)
         return {"successful": True, "changed_count": changed_count}