Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Commit e0b5c7f

Browse files
authored
dev: Fix lint on local with lint.local (#1113)
1 parent 33fa5a8 commit e0b5c7f

4 files changed

Lines changed: 42 additions & 6 deletions

File tree

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ repos:
44
- id: lint
55
name: lint
66
description: "Lint and sort"
7-
entry: make lint
7+
entry: make lint.local
88
pass_filenames: false
99
require_serial: true
1010
language: system

Makefile

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ build.portable:
4343
--build-arg COMMIT_SHA="${sha}" \
4444
--build-arg RELEASE_VERSION="${release_version}"
4545

46-
lint:
47-
make lint.install
48-
make lint.run
49-
5046
test:
5147
COVERAGE_CORE=sysmon pytest --cov=./ --junitxml=junit.xml -o junit_family=legacy
5248

@@ -56,11 +52,23 @@ test.unit:
5652
test.integration:
5753
COVERAGE_CORE=sysmon pytest --cov=./ -m "integration" --cov-report=xml:integration.coverage.xml --junitxml=integration.junit.xml -o junit_family=legacy
5854

55+
lint:
56+
make lint.install
57+
make lint.run
5958

59+
# used for CI
6060
lint.install:
6161
echo "Installing..."
6262
pip install -Iv ruff
6363

64+
lint.local:
65+
make lint.install.local
66+
make lint.run
67+
68+
lint.install.local:
69+
echo "Installing..."
70+
uv add --dev ruff
71+
6472
# The preferred method (for now) w.r.t. fixable rules is to manually update the makefile
6573
# with --fix and re-run 'make lint.' Since ruff is constantly adding rules this is a slight
6674
# amount of "needed" friction imo.

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ dev-dependencies = [
7373
"pytest-mock>=1.13.0",
7474
"pytest-sqlalchemy>=0.2.1",
7575
"respx>=0.20.2",
76+
"ruff>=0.9.8",
7677
"sqlalchemy-utils>=0.41.2",
7778
"time-machine>=2.16.0",
7879
# NOTE: some weird interaction between existing `vcrpy` snapshots and the way
@@ -84,4 +85,4 @@ dev-dependencies = [
8485
[tool.uv.sources]
8586
timestring = { git = "https://github.com/codecov/timestring", rev = "d37ceacc5954dff3b5bd2f887936a98a668dda42" }
8687
test-results-parser = { git = "https://github.com/codecov/test-results-parser", rev = "190bbc8a911099749928e13d5fe57f6027ca1e74" }
87-
shared = { git = "https://github.com/codecov/shared", rev = "47fa7fd405cd4a37ab6df9f200d6b600795f2786" }
88+
shared = { git = "https://github.com/codecov/shared", rev = "47fa7fd405cd4a37ab6df9f200d6b600795f2786" }

uv.lock

Lines changed: 27 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)