Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Commit fc29e8f

Browse files
committed
Remove label_index feature flag
It turns out this feature flag was never fully rolled out, and is part of ATS (automated test selection) which was also not fully launched. This will now remove this feature flag, as a precursor to removing labels altogether.
1 parent 2973343 commit fc29e8f

10 files changed

Lines changed: 30 additions & 2475 deletions

File tree

rollouts/__init__.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@
44
FLAKY_TEST_DETECTION = Feature("flaky_test_detection")
55
FLAKY_SHADOW_MODE = Feature("flaky_shadow_mode")
66

7-
# Eventually we want all repos to use this
8-
# This flag will just help us with the rollout process
9-
USE_LABEL_INDEX_IN_REPORT_PROCESSING_BY_REPO_ID = Feature(
10-
"use_label_index_in_report_processing"
11-
)
12-
137
PARALLEL_UPLOAD_PROCESSING_BY_REPO = Feature("parallel_upload_processing")
148

159
CARRYFORWARD_BASE_SEARCH_RANGE_BY_OWNER = Feature("carryforward_base_search_range")

services/report/languages/pycoverage.py

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -28,22 +28,13 @@ def process(
2828
] + [(COVERAGE_MISS, ln) for ln in file_coverage["missing_lines"]]
2929
for cov, ln in lines_and_coverage:
3030
if ln > 0:
31-
label_list_of_lists: list[list[str]] | list[list[int]] = []
32-
if report_builder_session.should_use_label_index:
33-
label_list_of_lists = [
34-
[single_id]
35-
for single_id in labels_table._get_list_of_label_ids(
36-
report_builder_session.label_index,
37-
file_coverage.get("contexts", {}).get(str(ln), []),
38-
)
39-
]
40-
else:
41-
label_list_of_lists = [
42-
[labels_table._normalize_label(testname)]
43-
for testname in file_coverage.get("contexts", {}).get(
44-
str(ln), []
45-
)
46-
]
31+
# label_list_of_lists: list[list[str]] | list[list[int]] = []
32+
label_list_of_lists = [
33+
[labels_table._normalize_label(testname)]
34+
for testname in file_coverage.get("contexts", {}).get(
35+
str(ln), []
36+
)
37+
]
4738
_file.append(
4839
ln,
4940
report_builder_session.create_coverage_line(

services/report/languages/tests/unit/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ def create_report_builder_session(
66
path_fixer: PathFixer | None = None,
77
filename: str = "filename",
88
current_yaml: dict | None = None,
9-
should_use_label_index: bool = False,
109
) -> ReportBuilderSession:
1110
def fixes(filename, bases_to_try=None):
1211
return filename
@@ -16,6 +15,5 @@ def fixes(filename, bases_to_try=None):
1615
ignored_lines={},
1716
sessionid=0,
1817
current_yaml=current_yaml,
19-
should_use_label_index=should_use_label_index,
2018
)
2119
return report_builder.create_report_builder_session(filename)

0 commit comments

Comments
 (0)