remove SQL metrics from worker tasks#1136
Conversation
🚨 Sentry detected 7 potential issues in your recent changes 🚨
Lower risk findings
|
adrian-codecov
left a comment
There was a problem hiding this comment.
Approved pending tests fixed, and confirmation from the team nobody needs/wants this feature
688d201 to
b9f4f75
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
==========================================
- Coverage 97.79% 97.77% -0.02%
==========================================
Files 446 444 -2
Lines 36799 36637 -162
==========================================
- Hits 35986 35821 -165
- Misses 813 816 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
if they need/want this feature we need to recreate the tables with partitions anyway. when i last tried months ago queries were so slow that metabase couldn't even run the query for a single day |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
i don't think anyone but me ever actually used these metrics? i am going to delete them, and delete the exposure logging in the
Featuresystem in shared, to cut down on writes and logs and whatallLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.