Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

remove SQL metrics from worker tasks#1136

Merged
matt-codecov merged 1 commit intomainfrom
matt/remove-sql-metrics
Mar 12, 2025
Merged

remove SQL metrics from worker tasks#1136
matt-codecov merged 1 commit intomainfrom
matt/remove-sql-metrics

Conversation

@matt-codecov
Copy link
Copy Markdown
Contributor

i don't think anyone but me ever actually used these metrics? i am going to delete them, and delete the exposure logging in the Feature system in shared, to cut down on writes and logs and whatall

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@matt-codecov matt-codecov requested a review from a team March 12, 2025 17:10
@matt-codecov matt-codecov enabled auto-merge March 12, 2025 17:10
@seer-by-sentry
Copy link
Copy Markdown
Contributor

seer-by-sentry Bot commented Mar 12, 2025

🚨 Sentry detected 7 potential issues in your recent changes 🚨

Lower risk findings

Copy link
Copy Markdown
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending tests fixed, and confirmation from the team nobody needs/wants this feature

@matt-codecov matt-codecov force-pushed the matt/remove-sql-metrics branch from 688d201 to b9f4f75 Compare March 12, 2025 19:12
@matt-codecov matt-codecov added this pull request to the merge queue Mar 12, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (a96d25e) to head (b9f4f75).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1136      +/-   ##
==========================================
- Coverage   97.79%   97.77%   -0.02%     
==========================================
  Files         446      444       -2     
  Lines       36799    36637     -162     
==========================================
- Hits        35986    35821     -165     
- Misses        813      816       +3     
Flag Coverage Δ
integration 42.90% <100.00%> (+0.02%) ⬆️
unit 90.47% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-codecov matt-codecov removed this pull request from the merge queue due to a manual request Mar 12, 2025
@matt-codecov matt-codecov added this pull request to the merge queue Mar 12, 2025
@matt-codecov
Copy link
Copy Markdown
Contributor Author

and confirmation from the team nobody needs/wants this feature

if they need/want this feature we need to recreate the tables with partitions anyway. when i last tried months ago queries were so slow that metabase couldn't even run the query for a single day

Merged via the queue into main with commit 4a44e42 Mar 12, 2025
19 of 25 checks passed
@matt-codecov matt-codecov deleted the matt/remove-sql-metrics branch March 12, 2025 19:27
@sentry
Copy link
Copy Markdown

sentry Bot commented Mar 13, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ DataError: ["raised as a result of Query-invoked autoflush; consider using a session.no_autoflush block if this flush is occurring prematurely"] app.tasks.upload.PreProcessUpload View Issue
  • ‼️ DataError: ["raised as a result of Query-invoked autoflush; consider using a session.no_autoflush block if this flush is occurring prematurely"] app.tasks.upload.Upload View Issue
  • ‼️ ConnectionError: Error 104 while writing to socket. Connection reset by peer. app.tasks.cache_rollup.CacheTestRollupsRedisTask View Issue
  • ‼️ TypeError: TestResultsProcessorTask.run_impl() missing 1 required positional argument: 'previous_result' app.tasks.test_results.TestResultsProcessor View Issue
  • ‼️ ChordError: Dependency f3c22af4-db01-43de-bb5d-216809c0c236 raised TypeError("TestResultsProcessorTask.run_impl() missing 1 required positional argument: 'previous_result'") app.tasks.test_results.TestResultsProcessor View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants