This repository was archived by the owner on May 5, 2025. It is now read-only.
Allow unrolling subqueries in cleanup task#1156
Merged
Conversation
Swatinem
commented
Mar 19, 2025
Comment on lines
+76
to
+81
| # This test factory implicitly creates: | ||
| # - Test with a Repository and an Owner, Upload, CommitReport. | ||
| # - An Upload with a CommitReport, a Commit that has a different Owner and | ||
| # one more Repository with yet another different Owner. | ||
| # And then also a Branch and a Pull via DB triggers because of the Commit. | ||
| remaining = TestInstanceFactory() |
Contributor
Author
There was a problem hiding this comment.
lol, these damn recursive factories :-D
Contributor
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
- Coverage 97.77% 97.76% -0.01%
==========================================
Files 444 443 -1
Lines 36574 36529 -45
==========================================
- Hits 35760 35714 -46
- Misses 814 815 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
giovanni-guidini
approved these changes
Mar 20, 2025
Contributor
giovanni-guidini
left a comment
giovanni-guidini
left a comment
There was a problem hiding this comment.
That's some very advanced query magic
For some reason, our postgres is unable to properly optimize a delete query on certain tables, which are using a subquery in the where clause. It turns out that unrolling that subquery within Python works just fine however. So lets do just that. As we are building all of the delete queries dynamically based on django relations (or some manually defined ones as well), we have to use some queryset magic as well to reverse those automatically created subqueries. So another method was added which can parse the `IN (...)` subquery out of a queryset, in order to execute that separately, and issue N+1 delete queries on the target table.
Swatinem
force-pushed
the
swatinem/unroll-delete-subqueries
branch
from
78dc751 to
0fec242
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, our postgres is unable to properly optimize a delete query on certain tables, which are using a subquery in the where clause.
It turns out that unrolling that subquery within Python works just fine however. So lets do just that.
As we are building all of the delete queries dynamically based on django relations (or some manually defined ones as well), we have to use some queryset magic as well to reverse those automatically created subqueries.
So another method was added which can parse the
IN (...)subquery out of a queryset, in order to execute that separately, and issue N+1 delete queries on the target table.