Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Revert "Bundle analysis: carryforward at most once per commit (#1131)"#1173

Merged
Swatinem merged 1 commit intomainfrom
swatinem/revert-ba-carryforward
Mar 25, 2025
Merged

Revert "Bundle analysis: carryforward at most once per commit (#1131)"#1173
Swatinem merged 1 commit intomainfrom
swatinem/revert-ba-carryforward

Conversation

@Swatinem
Copy link
Copy Markdown
Contributor

This reverts commit 51eb407.


Reverting this in an attempt to fix DB performance issues.

The Upload table is one of our biggest. And queries on it are unfortunately very slow, so we should avoid touching it as much as we can.

@Swatinem Swatinem requested a review from a team March 25, 2025 13:43
@Swatinem Swatinem self-assigned this Mar 25, 2025
@Swatinem Swatinem enabled auto-merge March 25, 2025 13:45
@seer-by-sentry
Copy link
Copy Markdown
Contributor

✅ Sentry found no issues in your recent changes ✅

@Swatinem Swatinem added this pull request to the merge queue Mar 25, 2025
@codecov-notifications
Copy link
Copy Markdown

codecov-notifications Bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (725a8d1) to head (ce4b9ac).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1173   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files         449      449           
  Lines       36864    36843   -21     
=======================================
- Hits        36026    36006   -20     
+ Misses        838      837    -1     
Flag Coverage Δ
integration 42.84% <0.00%> (-0.05%) ⬇️
unit 90.48% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit f70723d Mar 25, 2025
28 of 29 checks passed
@Swatinem Swatinem deleted the swatinem/revert-ba-carryforward branch March 25, 2025 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants