This repository was archived by the owner on May 5, 2025. It is now read-only.
fix: handle None diffs in coverage change checks#1175
Merged
Conversation
Contributor
Author
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1175 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 453 454 +1
Lines 37117 37144 +27
=======================================
+ Hits 36273 36300 +27
Misses 844 844
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
nora-shap
force-pushed
the
autofix/fix-none-diff-coverage-checks
branch
from
7ba2907 to
e5719b3
Compare
Swatinem
approved these changes
Mar 26, 2025
Contributor
Swatinem
left a comment
Swatinem
left a comment
There was a problem hiding this comment.
looks completely reasonable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hi there! This PR was automatically generated by Autofix 🤖
This fix was triggered by Nora Shapiro
Fixes WORKER-RHQ
Nonediffs in_check_coverage_changeand_check_uncovered_patchto prevent errors when no diff is available.get_diffreturnsNone.If you have any questions or feedback for the Sentry team about this fix, please email autofix@sentry.io with the Run ID: 13763.