This repository was archived by the owner on May 5, 2025. It is now read-only.
fix: ta_timeseries flake set and dict#1180
Merged
joseph-sentry merged 2 commits intomainfrom Mar 27, 2025
Merged
Conversation
there's a deadlock error that happens where the timescale background worker is running background jobs and we're altering the schema of the tables on which it's running the background job on, so we stop the background worker momentarily to allow the migrations to run.
Contributor
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
- Coverage 97.72% 97.72% -0.01%
==========================================
Files 453 455 +2
Lines 37117 37154 +37
==========================================
+ Hits 36273 36309 +36
- Misses 844 845 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Swatinem
approved these changes
Mar 27, 2025
| @@ -22,15 +22,16 @@ | |||
|
|
|||
| def get_flaky_tests_set(repo_id: int) -> set[bytes]: | |||
| return set( | |||
Contributor
There was a problem hiding this comment.
in this case you can also use a set comprehension literal
when we get bytes out of the DB using django it returns them as a memoryview so if you want the actual values in bytes you must call the bytes constructor on the memoryview
joseph-sentry
force-pushed
the
joseph/fix-ta-timeseries
branch
from
d770441 to
1ab5558
Compare
auto-merge was automatically disabled
March 27, 2025 14:48
Pull Request is not mergeable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when we get bytes out of the DB using django it returns them as a
memoryview so if you want the actual values in bytes you must call
the bytes constructor on the memoryview