Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

fix: update get_ta_url to handle null branch#1181

Merged
joseph-sentry merged 2 commits intomainfrom
joseph/fix-url
Mar 28, 2025
Merged

fix: update get_ta_url to handle null branch#1181
joseph-sentry merged 2 commits intomainfrom
joseph/fix-url

Conversation

@joseph-sentry
Copy link
Copy Markdown
Contributor

No description provided.

there's a deadlock error that happens where the timescale background
worker is running background jobs and we're altering the schema of
the tables on which it's running the background job on, so we stop the
background worker momentarily to allow the migrations to run.
@joseph-sentry joseph-sentry requested a review from a team March 26, 2025 19:01
@seer-by-sentry
Copy link
Copy Markdown
Contributor

✅ Sentry found no issues in your recent changes ✅

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications Bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/urls.py 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.72%. Comparing base (dba53c5) to head (2765ece).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/urls.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1181      +/-   ##
==========================================
- Coverage   97.72%   97.72%   -0.01%     
==========================================
  Files         453      455       +2     
  Lines       37117    37157      +40     
==========================================
+ Hits        36273    36311      +38     
- Misses        844      846       +2     
Flag Coverage Δ
integration 42.80% <90.90%> (+0.01%) ⬆️
unit 90.55% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread services/urls.py Outdated
if commit.branch is not None:
branch_name = quote_plus(commit.branch)
else:
branch_name = "main"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you have access to Repository, please pick the main branch as it is stored in repo. (and also push that through quote_plus)

@joseph-sentry joseph-sentry added this pull request to the merge queue Mar 28, 2025
Merged via the queue into main with commit e932541 Mar 28, 2025
23 of 29 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-url branch March 28, 2025 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants