Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

fix: update test results finisher to split out old impl#1182

Merged
joseph-sentry merged 2 commits intomainfrom
joseph/old-impl
Mar 27, 2025
Merged

fix: update test results finisher to split out old impl#1182
joseph-sentry merged 2 commits intomainfrom
joseph/old-impl

Conversation

@joseph-sentry
Copy link
Copy Markdown
Contributor

deps on: #1177

there's a deadlock error that happens where the timescale background
worker is running background jobs and we're altering the schema of
the tables on which it's running the background job on, so we stop the
background worker momentarily to allow the migrations to run.
@joseph-sentry joseph-sentry requested a review from a team March 26, 2025 19:17
@seer-by-sentry
Copy link
Copy Markdown
Contributor

✅ Sentry found no issues in your recent changes ✅

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.72%. Comparing base (dba53c5) to head (6a224b0).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/test_results_finisher.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
- Coverage   97.72%   97.72%   -0.01%     
==========================================
  Files         453      453              
  Lines       37117    37129      +12     
==========================================
+ Hits        36273    36284      +11     
- Misses        844      845       +1     
Flag Coverage Δ
integration 42.81% <95.65%> (+0.01%) ⬆️
unit 90.53% <73.91%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications Bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/test_results_finisher.py 90.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@joseph-sentry joseph-sentry added this pull request to the merge queue Mar 27, 2025
Merged via the queue into main with commit 959d16d Mar 27, 2025
26 of 29 checks passed
@joseph-sentry joseph-sentry deleted the joseph/old-impl branch March 27, 2025 14:44
@sentry
Copy link
Copy Markdown

sentry Bot commented Mar 27, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValueError: not enough values to unpack (expected 2, got 1) app.tasks.test_results.TestResultsFinisherTask View Issue
  • ‼️ RepositoryWithoutValidBotError app.tasks.test_results.TestResultsFinisherTask View Issue
  • ‼️ IntegrityError: (psycopg2.errors.UniqueViolation) duplicate key value violates unique constraint "reports_testresultreporttotals_report_id_key" app.tasks.test_results.TestResultsFinisherTask View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants