Bundle Analysis: Remove logging noise from retries#1186
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: tasks/bundle_analysis_processor.py
Did you find this useful? React with a 👍 or 👎 |
| @@ -195,18 +195,10 @@ def process_impl_within_lock( | |||
| result.update_upload(carriedforward=carriedforward) | |||
|
|
|||
| processing_results.append(result.as_dict()) | |||
There was a problem hiding this comment.
Putting SQLAlchemyError in the catch all.
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 455 455
Lines 37205 37203 -2
=======================================
- Hits 36354 36353 -1
+ Misses 851 850 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2 participants
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.