fix(ta): pass impl_type in finisher#1187
Conversation
we are currently not passing the impl_type to the rollups and flakes tasks in the finisher, even though the impl_type might be both, which means the tasks aren't running the logic they should be according to the feature flag
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: tasks/test_results_finisher.py
Did you find this useful? React with a 👍 or 👎 |
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 455 455
Lines 37203 37201 -2
=======================================
- Hits 36353 36352 -1
+ Misses 850 849 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
we are currently not passing the impl_type to the rollups and flakes tasks in the finisher, even though the impl_type might be both, which means the tasks aren't running the logic they should be according to the feature flag