This repository was archived by the owner on May 5, 2025. It is now read-only.
fix: step 3 of changing cache task args#1198
Merged
joseph-sentry merged 1 commit intomainfrom Apr 4, 2025
Merged
Conversation
Contributor
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1198 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 454 454
Lines 37024 37021 -3
=======================================
- Hits 36173 36171 -2
+ Misses 851 850 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adrian-codecov
approved these changes
Apr 1, 2025
Swatinem
reviewed
Apr 2, 2025
Swatinem
approved these changes
Apr 2, 2025
since all callers are using repo_id by this point we no longer have to accept repoid as an arg
joseph-sentry
force-pushed
the
joseph/args-step-3
branch
from
c647b51 to
e44257c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since all callers are using repo_id by this point we no longer have
to accept repoid as an arg