Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Prefix redis cache keys with cache:#1203

Merged
Swatinem merged 1 commit intomainfrom
swatinem/notify-cachekeys
Apr 2, 2025
Merged

Prefix redis cache keys with cache:#1203
Swatinem merged 1 commit intomainfrom
swatinem/notify-cachekeys

Conversation

@Swatinem
Copy link
Copy Markdown
Contributor

@Swatinem Swatinem commented Apr 2, 2025

The Sentry redis integration can automatically tag spans for use in the Sentry "Caches insights page" based on a prefix.

Although that insights page is pretty useless IMO, we might as well use it.

The Sentry redis integration can automatically tag spans for use in the Sentry "Caches insights page" based on a prefix.

Although that insights page is pretty useless IMO, we might as well use it.
@Swatinem Swatinem requested a review from a team April 2, 2025 12:04
@Swatinem Swatinem self-assigned this Apr 2, 2025
@seer-by-sentry
Copy link
Copy Markdown
Contributor

seer-by-sentry Bot commented Apr 2, 2025

✅ Sentry found no issues in your recent changes ✅

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications Bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (ad52223) to head (03f149d).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1203   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files         456      456           
  Lines       37053    37053           
=======================================
  Hits        36201    36201           
  Misses        852      852           
Flag Coverage Δ
integration 42.85% <50.00%> (ø)
unit 90.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swatinem Swatinem enabled auto-merge April 2, 2025 12:21
@Swatinem Swatinem added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit 60bf2e3 Apr 2, 2025
28 of 29 checks passed
@Swatinem Swatinem deleted the swatinem/notify-cachekeys branch April 2, 2025 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants