Skip to content

Commit 053e326

Browse files
michelletran-sentrymichelletran-sentry
committed
Reduce the number of characters in compiled codecov.sh
1 parent ab97788 commit 053e326

3 files changed

Lines changed: 84 additions & 81 deletions

File tree

‎dist/codecov.sh‎

Lines changed: 81 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ if [ -n "$CC_BINARY" ];
5252
then
5353
if [ -f "$CC_BINARY" ];
5454
then
55-
cc_filename=$CC_BINARY
56-
cc_command=$CC_BINARY
55+
cfilename=$CC_BINARY
56+
ccommand=$CC_BINARY
5757
else
5858
exit_if_error "Could not find binary file $CC_BINARY"
5959
fi
@@ -63,7 +63,7 @@ then
6363
exit_if_error "Could not install via pypi."
6464
exit
6565
fi
66-
cc_command="codecovcli"
66+
ccommand="codecovcli"
6767
else
6868
if [ -n "$CC_OS" ];
6969
then
@@ -79,17 +79,17 @@ else
7979
[[ $(arch) == "aarch64" && $family == "linux" ]] && CC_OS+="-arm64"
8080
say "$g==>$x Detected $b${CC_OS}$x"
8181
fi
82-
cc_filename="codecov"
83-
[[ $CC_OS == "windows" ]] && cc_filename+=".exe"
84-
cc_command="./$cc_filename"
82+
cfilename="codecov"
83+
[[ $CC_OS == "windows" ]] && cfilename+=".exe"
84+
ccommand="./$cfilename"
8585
[[ $CC_OS == "macos" ]] && \
8686
! command -v gpg 2>&1 >/dev/null && \
8787
HOMEBREW_NO_AUTO_UPDATE=1 brew install gpg
88-
cc_url="https://cli.codecov.io"
89-
cc_url="$cc_url/${CC_VERSION}"
90-
cc_url="$cc_url/${CC_OS}/${cc_filename}"
91-
say "$g ->$x Downloading $b${cc_url}$x"
92-
curl -O --retry 5 --retry-delay 2 "$cc_url"
88+
curl="https://cli.codecov.io"
89+
curl="$curl/${CC_VERSION}"
90+
curl="$curl/${CC_OS}/${cfilename}"
91+
say "$g ->$x Downloading $b${curl}$x"
92+
curl -O --retry 5 --retry-delay 2 "$curl"
9393
say "$g==>$x Finishing downloading $b${CC_OS}:${CC_VERSION}$x"
9494
version_url="https://cli.codecov.io/api/${CC_OS}/${CC_VERSION}"
9595
version=$(curl -s "$version_url" -H "Accept:application/json" | tr \{ '\n' | tr , '\n' | tr \} '\n' | grep "\"version\"" | awk -F'"' '{print $4}' | tail -1)
@@ -107,44 +107,44 @@ CC_PUBLIC_PGP_KEY=$(curl -s https://keybase.io/codecovsecurity/pgp_keys.asc)
107107
say "$g==>$x Verifying GPG signature integrity"
108108
sha_url="https://cli.codecov.io"
109109
sha_url="${sha_url}/${CC_VERSION}/${CC_OS}"
110-
sha_url="${sha_url}/${cc_filename}.SHA256SUM"
110+
sha_url="${sha_url}/${cfilename}.SHA256SUM"
111111
say "$g ->$x Downloading $b${sha_url}$x"
112112
say "$g ->$x Downloading $b${sha_url}.sig$x"
113113
say " "
114114
curl -Os --retry 5 --retry-delay 2 --connect-timeout 2 "$sha_url"
115115
curl -Os --retry 5 --retry-delay 2 --connect-timeout 2 "${sha_url}.sig"
116-
if ! gpg --verify "${cc_filename}.SHA256SUM.sig" "${cc_filename}.SHA256SUM";
116+
if ! gpg --verify "${cfilename}.SHA256SUM.sig" "${cfilename}.SHA256SUM";
117117
then
118118
exit_if_error "Could not verify signature. Please contact Codecov if problem continues"
119119
fi
120-
if ! (shasum -a 256 -c "${cc_filename}.SHA256SUM" 2>/dev/null || \
121-
sha256sum -c "${cc_filename}.SHA256SUM");
120+
if ! (shasum -a 256 -c "${cfilename}.SHA256SUM" 2>/dev/null || \
121+
sha256sum -c "${cfilename}.SHA256SUM");
122122
then
123123
exit_if_error "Could not verify SHASUM. Please contact Codecov if problem continues"
124124
fi
125125
say "$g==>$x CLI integrity verified"
126126
say
127-
chmod +x "$cc_command"
127+
chmod +x "$ccommand"
128128
fi
129129
if [ -n "$CC_BINARY_LOCATION" ];
130130
then
131-
mkdir -p "$CC_BINARY_LOCATION" && mv "$cc_filename" $_
131+
mkdir -p "$CC_BINARY_LOCATION" && mv "$cfilename" $_
132132
say "$g==>$x Codecov binary moved to ${CC_BINARY_LOCATION}"
133133
fi
134134
if [ "$CC_DOWNLOAD_ONLY" = "true" ];
135135
then
136136
say "$g==>$x Codecov download only called. Exiting..."
137137
fi
138-
cc_cli_args=()
139-
cc_cli_args+=( $(k_arg AUTO_LOAD_PARAMS_FROM) $(v_arg AUTO_LOAD_PARAMS_FROM))
140-
cc_cli_args+=( $(k_arg ENTERPRISE_URL) $(v_arg ENTERPRISE_URL))
138+
ccli_args=()
139+
ccli_args+=( $(k_arg AUTO_LOAD_PARAMS_FROM) $(v_arg AUTO_LOAD_PARAMS_FROM))
140+
ccli_args+=( $(k_arg ENTERPRISE_URL) $(v_arg ENTERPRISE_URL))
141141
if [ -n "$CC_YML_PATH" ]
142142
then
143-
cc_cli_args+=( "--codecov-yml-path" )
144-
cc_cli_args+=( "$CC_YML_PATH" )
143+
ccli_args+=( "--codecov-yml-path" )
144+
ccli_args+=( "$CC_YML_PATH" )
145145
fi
146-
cc_cli_args+=( $(write_bool_args CC_DISABLE_TELEM) )
147-
cc_cli_args+=( $(write_bool_args CC_VERBOSE) )
146+
ccli_args+=( $(write_bool_args CC_DISABLE_TELEM) )
147+
ccli_args+=( $(write_bool_args CC_VERBOSE) )
148148
if [ -n "$CC_TOKEN_VAR" ];
149149
then
150150
token="$(eval echo \$$CC_TOKEN_VAR)"
@@ -160,100 +160,103 @@ then
160160
token_arg+=( " -t " "$token")
161161
fi
162162
if [ "$CC_RUN_CMD" == "upload-coverage" ]; then
163-
cc_args=()
163+
cargs=()
164164
# Args for create commit
165-
cc_args+=( $(write_bool_args CC_FAIL_ON_ERROR) )
166-
cc_args+=( $(k_arg GIT_SERVICE) $(v_arg GIT_SERVICE))
167-
cc_args+=( $(k_arg PARENT_SHA) $(v_arg PARENT_SHA))
168-
cc_args+=( $(k_arg PR) $(v_arg PR))
169-
cc_args+=( $(k_arg SHA) $(v_arg SHA))
170-
cc_args+=( $(k_arg SLUG) $(v_arg SLUG))
165+
cargs+=( $(write_bool_args CC_FAIL_ON_ERROR) )
166+
cargs+=( $(k_arg GIT_SERVICE) $(v_arg GIT_SERVICE))
167+
cargs+=( $(k_arg PARENT_SHA) $(v_arg PARENT_SHA))
168+
cargs+=( $(k_arg PR) $(v_arg PR))
169+
cargs+=( $(k_arg SHA) $(v_arg SHA))
170+
cargs+=( $(k_arg SLUG) $(v_arg SLUG))
171171
# Args for create report
172-
cc_args+=( $(k_arg CODE) $(v_arg CODE))
172+
cargs+=( $(k_arg CODE) $(v_arg CODE))
173173
# Args for do upload
174-
cc_args+=( $(k_arg ENV) $(v_arg ENV))
174+
cargs+=( $(k_arg ENV) $(v_arg ENV))
175175
OLDIFS=$IFS;IFS=,
176-
cc_args+=( $(k_arg BRANCH) $(v_arg BRANCH))
177-
cc_args+=( $(k_arg BUILD) $(v_arg BUILD))
178-
cc_args+=( $(k_arg BUILD_URL) $(v_arg BUILD_URL))
179-
cc_args+=( $(k_arg DIR) $(v_arg DIR))
180-
cc_args+=( $(write_bool_args CC_DISABLE_FILE_FIXES) )
181-
cc_args+=( $(write_bool_args CC_DISABLE_SEARCH) )
182-
cc_args+=( $(write_bool_args CC_DRY_RUN) )
176+
cargs+=( $(k_arg BRANCH) $(v_arg BRANCH))
177+
cargs+=( $(k_arg BUILD) $(v_arg BUILD))
178+
cargs+=( $(k_arg BUILD_URL) $(v_arg BUILD_URL))
179+
cargs+=( $(k_arg DIR) $(v_arg DIR))
180+
cargs+=( $(write_bool_args CC_DISABLE_FILE_FIXES) )
181+
cargs+=( $(write_bool_args CC_DISABLE_SEARCH) )
182+
cargs+=( $(write_bool_args CC_DRY_RUN) )
183183
if [ -n "$CC_EXCLUDES" ];
184184
then
185185
for directory in $CC_EXCLUDES; do
186-
cc_args+=( "--exclude" "$directory" )
186+
cargs+=( "--exclude" "$directory" )
187187
done
188188
fi
189189
if [ -n "$CC_FILES" ];
190190
then
191191
for file in $CC_FILES; do
192-
cc_args+=( "--file" "$file" )
192+
cargs+=( "--file" "$file" )
193193
done
194194
fi
195195
if [ -n "$CC_FLAGS" ];
196196
then
197197
for flag in $CC_FLAGS; do
198-
cc_args+=( "--flag" "$flag" )
198+
cargs+=( "--flag" "$flag" )
199199
done
200200
fi
201-
cc_args+=( $(k_arg GCOV_ARGS) $(v_arg GCOV_ARGS))
202-
cc_args+=( $(k_arg GCOV_EXECUTABLE) $(v_arg GCOV_EXECUTABLE))
203-
cc_args+=( $(k_arg GCOV_IGNORE) $(v_arg GCOV_IGNORE))
204-
cc_args+=( $(k_arg GCOV_INCLUDE) $(v_arg GCOV_INCLUDE))
205-
cc_args+=( $(write_bool_args CC_HANDLE_NO_REPORTS_FOUND) )
206-
cc_args+=( $(write_bool_args CC_RECURSE_SUBMODULES) )
207-
cc_args+=( $(k_arg JOB_CODE) $(v_arg JOB_CODE))
208-
cc_args+=( $(write_bool_args CC_LEGACY) )
201+
cargs+=( $(k_arg GCOV_ARGS) $(v_arg GCOV_ARGS))
202+
cargs+=( $(k_arg GCOV_EXECUTABLE) $(v_arg GCOV_EXECUTABLE))
203+
cargs+=( $(k_arg GCOV_IGNORE) $(v_arg GCOV_IGNORE))
204+
cargs+=( $(k_arg GCOV_INCLUDE) $(v_arg GCOV_INCLUDE))
205+
cargs+=( $(write_bool_args CC_HANDLE_NO_REPORTS_FOUND) )
206+
cargs+=( $(write_bool_args CC_RECURSE_SUBMODULES) )
207+
cargs+=( $(k_arg JOB_CODE) $(v_arg JOB_CODE))
208+
cargs+=( $(write_bool_args CC_LEGACY) )
209209
if [ -n "$CC_NAME" ];
210210
then
211-
cc_args+=( "--name" "$CC_NAME" )
211+
cargs+=( "--name" "$CC_NAME" )
212212
fi
213-
cc_args+=( $(k_arg NETWORK_FILTER) $(v_arg NETWORK_FILTER))
214-
cc_args+=( $(k_arg NETWORK_PREFIX) $(v_arg NETWORK_PREFIX))
215-
cc_args+=( $(k_arg NETWORK_ROOT_FOLDER) $(v_arg NETWORK_ROOT_FOLDER))
213+
cargs+=( $(k_arg NETWORK_FILTER) $(v_arg NETWORK_FILTER))
214+
cargs+=( $(k_arg NETWORK_PREFIX) $(v_arg NETWORK_PREFIX))
215+
cargs+=( $(k_arg NETWORK_ROOT_FOLDER) $(v_arg NETWORK_ROOT_FOLDER))
216216
if [ -n "$CC_PLUGINS" ];
217217
then
218218
for plugin in $CC_PLUGINS; do
219-
cc_args+=( "--plugin" "$plugin" )
219+
cargs+=( "--plugin" "$plugin" )
220220
done
221221
fi
222-
cc_args+=( $(k_arg REPORT_TYPE) $(v_arg REPORT_TYPE))
223-
cc_args+=( $(k_arg SWIFT_PROJECT) $(v_arg SWIFT_PROJECT))
222+
cargs+=( $(k_arg REPORT_TYPE) $(v_arg REPORT_TYPE))
223+
cargs+=( $(k_arg SWIFT_PROJECT) $(v_arg SWIFT_PROJECT))
224224
IFS=$OLDIFS
225225
elif [ "$CC_RUN_CMD" == "empty-upload" ]; then
226-
cc_args=()
227-
cc_args+=( $(write_bool_args CC_FAIL_ON_ERROR) )
228-
cc_args+=( $(write_bool_args CC_FORCE) )
229-
cc_args+=( $(k_arg GIT_SERVICE) $(v_arg GIT_SERVICE))
230-
cc_args+=( $(k_arg SHA) $(v_arg SHA))
231-
cc_args+=( $(k_arg SLUG) $(v_arg SLUG))
226+
cargs=()
227+
cargs+=( $(k_arg BRANCH) $(v_arg BRANCH))
228+
cargs+=( $(write_bool_args CC_FAIL_ON_ERROR) )
229+
cargs+=( $(write_bool_args CC_FORCE) )
230+
cargs+=( $(k_arg GIT_SERVICE) $(v_arg GIT_SERVICE))
231+
cargs+=( $(k_arg PARENT_SHA) $(v_arg PARENT_SHA))
232+
cargs+=( $(k_arg PR) $(v_arg PR))
233+
cargs+=( $(k_arg SHA) $(v_arg SHA))
234+
cargs+=( $(k_arg SLUG) $(v_arg SLUG))
232235
elif [ "$CC_RUN_CMD" == "pr-base-picking" ]; then
233-
cc_args=()
234-
cc_args+=( $(k_arg BASE_SHA) $(v_arg BASE_SHA))
235-
cc_args+=( $(k_arg PR) $(v_arg PR))
236-
cc_args+=( $(k_arg SLUG) $(v_arg SLUG))
237-
cc_args+=( $(k_arg SERVICE) $(v_arg SERVICE))
236+
cargs=()
237+
cargs+=( $(k_arg BASE_SHA) $(v_arg BASE_SHA))
238+
cargs+=( $(k_arg PR) $(v_arg PR))
239+
cargs+=( $(k_arg SLUG) $(v_arg SLUG))
240+
cargs+=( $(k_arg SERVICE) $(v_arg SERVICE))
238241
elif [ "$CC_RUN_CMD" == "send-notifications" ]; then
239-
cc_args=()
240-
cc_args+=( $(k_arg SHA) $(v_arg SHA))
241-
cc_args+=( $(write_bool_args CC_FAIL_ON_ERROR) )
242-
cc_args+=( $(k_arg GIT_SERVICE) $(v_arg GIT_SERVICE))
243-
cc_args+=( $(k_arg SLUG) $(v_arg SLUG))
242+
cargs=()
243+
cargs+=( $(k_arg SHA) $(v_arg SHA))
244+
cargs+=( $(write_bool_args CC_FAIL_ON_ERROR) )
245+
cargs+=( $(k_arg GIT_SERVICE) $(v_arg GIT_SERVICE))
246+
cargs+=( $(k_arg SLUG) $(v_arg SLUG))
244247
else
245248
exit_if_error "Invalid run command specified: $CC_RUN_CMD"
246249
exit
247250
fi
248251
unset NODE_OPTIONS
249252
# https://github.com/codecov/uploader/issues/475
250253
say "$g==>$x Running $CC_RUN_CMD"
251-
say " $b$cc_command $(echo "${cc_cli_args[@]}") $CC_RUN_CMD$token_str $(echo "${cc_args[@]}")$x"
252-
if ! $cc_command \
253-
${cc_cli_args[*]} \
254+
say " $b$ccommand $(echo "${ccli_args[@]}") $CC_RUN_CMD$token_str $(echo "${cargs[@]}")$x"
255+
if ! $ccommand \
256+
${ccli_args[*]} \
254257
${CC_RUN_CMD} \
255258
${token_arg[*]} \
256-
"${cc_args[@]}";
259+
"${cargs[@]}";
257260
then
258261
exit_if_error "Failed to run $CC_RUN_CMD"
259262
fi

‎package.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def package_scripts(source_dir, source_root, outfile):
2626

2727
print(f"Current script is {len(''.join(lines))} (max: 8192) chars.")
2828
if len(''.join(lines)) > 8192:
29-
print("Due to windows limitiations, script must be under 8192 chars.")
29+
print("Due to windows limitations, script must be under 8192 chars.")
3030
exit(1)
3131

3232
def _get_vars(line):
@@ -58,7 +58,7 @@ def _parse(file):
5858
return lines
5959

6060
def _shorten_line(line):
61-
return line.replace("CODECOV", "CC").replace("codecov_", "cc_")
61+
return line.replace("CODECOV", "CC").replace("codecov_", "c")
6262

6363
def _get_script_from_line(line):
6464
matcher = r'\s*\. \.\/(\S+\.sh)$' #. ./version.sh

‎scripts/set_empty_upload_args.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ codecov_args+=( $(k_arg GIT_SERVICE) $(v_arg GIT_SERVICE))
99
codecov_args+=( $(k_arg PARENT_SHA) $(v_arg PARENT_SHA))
1010
codecov_args+=( $(k_arg PR) $(v_arg PR))
1111
codecov_args+=( $(k_arg SHA) $(v_arg SHA))
12-
codecov_args+=( $(k_arg SLUG) $(v_arg SLUG))
12+
codecov_args+=( $(k_arg SLUG) $(v_arg SLUG))

0 commit comments

Comments
 (0)