Revert "Push non-primary emails to Lobbyside (other_emails column)"#3870
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will decrease total bundle size by 177.77kB (-0.45%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
Files in
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3869
Note
Low Risk
Scoped revert of third-party visitor metadata; reduces email data sent to Lobbyside with no auth or core app logic changes.
Overview
Reverts the Lobbyside integration change that sent non-primary user emails to the widget via an
other_emailscustom field.The widget no longer derives or pushes
other_emails:lobbysideCustomFieldsandsetVisitoronly includestages_completed,signed_up_date, andsubscription_type. The template’s{{did-update}}deps no longer watch that field.authenticator.syncCurrentUserno longer sideloadsemail-addresses, since it was only needed for that column. Related unit tests forother_emailsformatting are removed.Reviewed by Cursor Bugbot for commit 4145ab8. Bugbot is set up for automated code reviews on this repo. Configure here.