Handle missing FEN castling field without panicking#1097
Open
grepfuldead wants to merge 1 commit into
Open
Conversation
Board::from_fen returns Err for missing placement data or an invalid active color, but unwrapped the castling field, so a FEN truncated after the active color (for example "4k3/8/8/8/8/8/8/4K3 w") panicked in the parser instead of parsing. The trailing en passant / halfmove / fullmove fields already default via unwrap_or_default(); this makes the castling field consistent, so a missing or unrecognised castling field parses as no castling rights. Adds a regression test. No functional change. Bench: 2526370
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Board::from_fen returns Err for missing placement data or an invalid active color, but unwrapped the castling field, so a FEN truncated after the active color (for example "4k3/8/8/8/8/8/8/4K3 w") panicked in the parser instead of parsing.
The trailing en passant / halfmove / fullmove fields already default via unwrap_or_default(); this makes the castling field consistent, so a missing or unrecognised castling field parses as no castling rights. Adds a regression test.
No functional change.
Bench: 2526370