Skip to content

Commit 1788c7a

Browse files
codedmonkeycodedmonkey
committed
Update Version entity with metadata entities integration
Signed-off-by: Tim Goudriaan <tim@codedmonkey.com>
1 parent 7f9dfa7 commit 1788c7a

15 files changed

Lines changed: 243 additions & 95 deletions

‎migrations/Version20260121133359.php‎

Lines changed: 128 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,128 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace DoctrineMigrations;
6+
7+
use Doctrine\DBAL\Schema\Schema;
8+
use Doctrine\Migrations\AbstractMigration;
9+
10+
final class Version20260121133359 extends AbstractMigration
11+
{
12+
public function getDescription(): string
13+
{
14+
return 'Update version table for metadata refactoring';
15+
}
16+
17+
public function up(Schema $schema): void
18+
{
19+
$this->addCurrentMetadataColumnToVersionTable();
20+
$this->refactorVersionTableColumns();
21+
}
22+
23+
public function down(Schema $schema): void
24+
{
25+
$this->dropCurrentMetadataColumnFromVersionTable();
26+
$this->revertVersionTableColumns();
27+
}
28+
29+
private function addCurrentMetadataColumnToVersionTable(): void
30+
{
31+
$this->addSql(<<<'SQL'
32+
ALTER TABLE version ADD current_metadata_id INT DEFAULT NULL
33+
SQL);
34+
$this->addSql(<<<'SQL'
35+
ALTER TABLE
36+
version
37+
ADD
38+
CONSTRAINT FK_BF1CD3C3624A4280 FOREIGN KEY (current_metadata_id) REFERENCES metadata (id)
39+
SQL);
40+
$this->addSql(<<<'SQL'
41+
CREATE UNIQUE INDEX UNIQ_BF1CD3C3624A4280 ON version (current_metadata_id)
42+
SQL);
43+
44+
$this->addSql(<<<'SQL'
45+
UPDATE version
46+
SET current_metadata_id = metadata.id
47+
FROM metadata
48+
WHERE metadata.version_id = version.id
49+
SQL);
50+
}
51+
52+
public function refactorVersionTableColumns(): void
53+
{
54+
$this->addSql(<<<'SQL'
55+
DROP INDEX pkg_ver_idx
56+
SQL);
57+
$this->addSql(<<<'SQL'
58+
ALTER TABLE version RENAME COLUMN name TO package_name
59+
SQL);
60+
$this->addSql(<<<'SQL'
61+
ALTER TABLE version RENAME COLUMN version TO name
62+
SQL);
63+
$this->addSql(<<<'SQL'
64+
ALTER TABLE version RENAME COLUMN normalized_version TO normalized_name
65+
SQL);
66+
$this->addSql(<<<'SQL'
67+
CREATE UNIQUE INDEX package_version_idx ON version (package_id, normalized_name)
68+
SQL);
69+
70+
$this->addSql(<<<'SQL'
71+
ALTER TABLE version DROP CONSTRAINT fk_bf1cd3c3f44cabff
72+
SQL);
73+
$this->addSql(<<<'SQL'
74+
ALTER TABLE version ALTER package_id SET NOT NULL
75+
SQL);
76+
$this->addSql(<<<'SQL'
77+
ALTER TABLE
78+
version
79+
ADD
80+
CONSTRAINT FK_BF1CD3C3F44CABFF FOREIGN KEY (package_id) REFERENCES package (id) ON DELETE CASCADE NOT DEFERRABLE
81+
SQL);
82+
}
83+
84+
private function dropCurrentMetadataColumnFromVersionTable(): void
85+
{
86+
$this->addSql(<<<'SQL'
87+
ALTER TABLE version DROP CONSTRAINT FK_BF1CD3C3624A4280
88+
SQL);
89+
$this->addSql(<<<'SQL'
90+
DROP INDEX UNIQ_BF1CD3C3624A4280
91+
SQL);
92+
$this->addSql(<<<'SQL'
93+
ALTER TABLE version DROP current_metadata_id
94+
SQL);
95+
}
96+
97+
public function revertVersionTableColumns(): void
98+
{
99+
$this->addSql(<<<'SQL'
100+
DROP INDEX package_version_idx
101+
SQL);
102+
$this->addSql(<<<'SQL'
103+
ALTER TABLE version RENAME COLUMN name TO version
104+
SQL);
105+
$this->addSql(<<<'SQL'
106+
ALTER TABLE version RENAME COLUMN normalized_name TO normalized_version
107+
SQL);
108+
$this->addSql(<<<'SQL'
109+
ALTER TABLE version RENAME COLUMN package_name TO name
110+
SQL);
111+
$this->addSql(<<<'SQL'
112+
CREATE UNIQUE INDEX pkg_ver_idx ON version (package_id, normalized_version)
113+
SQL);
114+
115+
$this->addSql(<<<'SQL'
116+
ALTER TABLE version DROP CONSTRAINT FK_BF1CD3C3F44CABFF
117+
SQL);
118+
$this->addSql(<<<'SQL'
119+
ALTER TABLE version ALTER package_id DROP NOT NULL
120+
SQL);
121+
$this->addSql(<<<'SQL'
122+
ALTER TABLE
123+
version
124+
ADD
125+
CONSTRAINT fk_bf1cd3c3f44cabff FOREIGN KEY (package_id) REFERENCES package (id) NOT DEFERRABLE INITIALLY IMMEDIATE
126+
SQL);
127+
}
128+
}

‎src/Controller/ApiController.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public function packageDistribution(Request $request, string $reference, string
128128
throw $this->createNotFoundException();
129129
}
130130

131-
if (null === $version = $this->versionRepository->findOneByNormalizedVersion($package, $versionName)) {
131+
if (null === $version = $this->versionRepository->findOneByNormalizedVersionName($package, $versionName)) {
132132
throw $this->createNotFoundException();
133133
}
134134

‎src/Doctrine/Entity/Metadata.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ class Metadata extends TrackedEntity
8787
#[ORM\Column(nullable: true)]
8888
private ?\DateTimeImmutable $releasedAt = null;
8989

90-
#[ORM\ManyToOne(targetEntity: Version::class)]
90+
#[ORM\ManyToOne(targetEntity: Version::class, inversedBy: 'metadata')]
9191
#[ORM\JoinColumn(nullable: false, onDelete: 'CASCADE')]
9292
private Version $version;
9393

‎src/Doctrine/Entity/Package.php‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ public function getVersion(string $normalizedVersion): ?Version
276276
if (!isset($this->cachedVersions)) {
277277
$this->cachedVersions = [];
278278
foreach ($this->getVersions() as $version) {
279-
$this->cachedVersions[strtolower($version->getNormalizedVersion())] = $version;
279+
$this->cachedVersions[strtolower($version->getNormalizedName())] = $version;
280280
}
281281
}
282282

@@ -419,25 +419,25 @@ public function getActiveVersions(): array
419419
$activePrereleaseVersions = [];
420420

421421
foreach ($this->getSortedVersions() as $version) {
422-
if ('stable' !== VersionParser::parseStability($version->getNormalizedVersion())) {
422+
if ('stable' !== VersionParser::parseStability($version->getNormalizedName())) {
423423
continue;
424424
}
425425

426-
[$majorVersion, $minorVersion] = explode('.', $version->getNormalizedVersion());
426+
[$majorVersion, $minorVersion] = explode('.', $version->getNormalizedName());
427427

428428
if ('0' === $majorVersion) {
429429
$prereleaseVersion = "$majorVersion.$minorVersion";
430430

431431
$activePrereleaseVersions[$prereleaseVersion] ??= $version;
432-
if (version_compare($version->getNormalizedVersion(), $activePrereleaseVersions[$prereleaseVersion]->getNormalizedVersion(), '>')) {
432+
if (version_compare($version->getNormalizedName(), $activePrereleaseVersions[$prereleaseVersion]->getNormalizedName(), '>')) {
433433
$activePrereleaseVersions[$prereleaseVersion] = $version;
434434
}
435435

436436
continue;
437437
}
438438

439439
$activeVersions[$majorVersion] ??= $version;
440-
if (version_compare($version->getNormalizedVersion(), $activeVersions[$majorVersion]->getNormalizedVersion(), '>')) {
440+
if (version_compare($version->getNormalizedName(), $activeVersions[$majorVersion]->getNormalizedName(), '>')) {
441441
$activeVersions[$majorVersion] = $version;
442442
}
443443
}
@@ -447,34 +447,34 @@ public function getActiveVersions(): array
447447

448448
// Find newer unstable releases of active versions
449449
foreach ($this->getSortedVersions() as $version) {
450-
if (in_array(VersionParser::parseStability($version->getNormalizedVersion()), ['stable', 'dev'], true)) {
450+
if (in_array(VersionParser::parseStability($version->getNormalizedName()), ['stable', 'dev'], true)) {
451451
continue;
452452
}
453453

454-
[$majorVersion, $minorVersion] = explode('.', $version->getNormalizedVersion());
454+
[$majorVersion, $minorVersion] = explode('.', $version->getNormalizedName());
455455

456456
$developmentVersion = "$majorVersion.$minorVersion";
457457

458458
if ('0' === $majorVersion) {
459-
if (isset($activePrereleaseVersions[$developmentVersion]) && !version_compare($version->getNormalizedVersion(), $activePrereleaseVersions[$developmentVersion]->getNormalizedVersion(), '>')) {
459+
if (isset($activePrereleaseVersions[$developmentVersion]) && !version_compare($version->getNormalizedName(), $activePrereleaseVersions[$developmentVersion]->getNormalizedName(), '>')) {
460460
continue;
461461
}
462462

463463
$activePrereleaseDevelopmentVersions[$developmentVersion] ??= $version;
464-
if (version_compare($version->getNormalizedVersion(), $activePrereleaseDevelopmentVersions[$developmentVersion]->getNormalizedVersion(), '>')) {
464+
if (version_compare($version->getNormalizedName(), $activePrereleaseDevelopmentVersions[$developmentVersion]->getNormalizedName(), '>')) {
465465
$activePrereleaseDevelopmentVersions[$developmentVersion] = $version;
466466
}
467467

468468
continue;
469469
}
470470

471-
if (isset($activeVersions[$majorVersion]) && !version_compare($version->getNormalizedVersion(), $activeVersions[$majorVersion]->getNormalizedVersion(), '>')) {
471+
if (isset($activeVersions[$majorVersion]) && !version_compare($version->getNormalizedName(), $activeVersions[$majorVersion]->getNormalizedName(), '>')) {
472472
continue;
473473
}
474474

475475
$activeDevelopmentVersions[$developmentVersion] ??= $version;
476-
if (version_compare($version->getNormalizedVersion(), $activeDevelopmentVersions[$developmentVersion]->getNormalizedVersion(), '>')) {
477-
$activeDevelopmentVersions[$version->getNormalizedVersion()] = $version;
476+
if (version_compare($version->getNormalizedName(), $activeDevelopmentVersions[$developmentVersion]->getNormalizedName(), '>')) {
477+
$activeDevelopmentVersions[$version->getNormalizedName()] = $version;
478478
}
479479
}
480480

@@ -514,7 +514,7 @@ public function getHistoricalVersions(): array
514514
public function getDevVersions(): array
515515
{
516516
return array_filter($this->getSortedVersions(), static function (Version $version) {
517-
if (str_ends_with($version->getNormalizedVersion(), '.9999999-dev')) {
517+
if (str_ends_with($version->getNormalizedName(), '.9999999-dev')) {
518518
return true;
519519
}
520520

@@ -531,13 +531,13 @@ public function getDevVersions(): array
531531
*/
532532
public function getDevBranchVersions(): array
533533
{
534-
return array_filter($this->getSortedVersions(), static fn (Version $version) => str_starts_with($version->getNormalizedVersion(), 'dev-'));
534+
return array_filter($this->getSortedVersions(), static fn (Version $version) => str_starts_with($version->getNormalizedName(), 'dev-'));
535535
}
536536

537537
public static function sortVersions(Version $a, Version $b): int
538538
{
539-
$aVersion = $a->getNormalizedVersion();
540-
$bVersion = $b->getNormalizedVersion();
539+
$aVersion = $a->getNormalizedName();
540+
$bVersion = $b->getNormalizedName();
541541

542542
// use branch alias for sorting if one is provided
543543
if (isset($a->getExtra()['branch-alias'][$aVersion])) {
@@ -562,7 +562,7 @@ public static function sortVersions(Version $a, Version $b): int
562562
if ($aVersion === $bVersion) {
563563
// make sure sort is stable
564564
if ($a->getReleasedAt() === $b->getReleasedAt()) {
565-
return $a->getNormalizedVersion() <=> $b->getNormalizedVersion();
565+
return $a->getNormalizedName() <=> $b->getNormalizedName();
566566
}
567567

568568
return $b->getReleasedAt() > $a->getReleasedAt() ? 1 : -1;

0 commit comments

Comments
 (0)