Skip to content

Commit 3b57f9a

Browse files
committed
Merge branch 'enums'
2 parents 7cc3cb6 + c99936a commit 3b57f9a

25 files changed

Lines changed: 127 additions & 87 deletions

src/Composer/ConfigFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
namespace CodedMonkey\Dirigent\Composer;
66

77
use CodedMonkey\Dirigent\Doctrine\Entity\Credentials;
8-
use CodedMonkey\Dirigent\Doctrine\Entity\CredentialsType;
98
use CodedMonkey\Dirigent\Doctrine\Entity\Registry;
9+
use CodedMonkey\Dirigent\Entity\CredentialsType;
1010
use Composer\Config;
1111
use Composer\Factory;
1212

src/Controller/ApiController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
use CodedMonkey\Dirigent\Attribute\IsGrantedAccess;
88
use CodedMonkey\Dirigent\Attribute\MapPackage;
99
use CodedMonkey\Dirigent\Doctrine\Entity\Package;
10-
use CodedMonkey\Dirigent\Doctrine\Entity\PackageFetchStrategy;
1110
use CodedMonkey\Dirigent\Doctrine\Repository\PackageRepository;
1211
use CodedMonkey\Dirigent\Doctrine\Repository\VersionRepository;
12+
use CodedMonkey\Dirigent\Entity\PackageFetchStrategy;
1313
use CodedMonkey\Dirigent\Entity\PackageUpdateSource;
1414
use CodedMonkey\Dirigent\Message\TrackInstallations;
1515
use CodedMonkey\Dirigent\Message\UpdatePackage;

src/Controller/Dashboard/DashboardCredentialsController.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
namespace CodedMonkey\Dirigent\Controller\Dashboard;
66

77
use CodedMonkey\Dirigent\Doctrine\Entity\Credentials;
8-
use CodedMonkey\Dirigent\Doctrine\Entity\CredentialsType;
8+
use CodedMonkey\Dirigent\Entity\CredentialsType;
99
use EasyCorp\Bundle\EasyAdminBundle\Attribute\AdminRoute;
1010
use EasyCorp\Bundle\EasyAdminBundle\Config\Crud;
1111
use EasyCorp\Bundle\EasyAdminBundle\Controller\AbstractCrudController;
@@ -37,10 +37,8 @@ public function configureFields(string $pageName): iterable
3737
yield TextareaField::new('description')
3838
->onlyOnForms();
3939
yield ChoiceField::new('type')
40-
->setTemplatePath('dashboard/fields/credentials_type.html.twig')
4140
->setRequired(true)
4241
->setChoices(CredentialsType::cases())
43-
->setFormTypeOption('choice_label', static fn (CredentialsType $choice): string => "credentials.type.{$choice->value}")
4442
->renderExpanded();
4543
yield TextField::new('username')
4644
->setFormTypeOption('row_attr', ['data-credentials-field' => 'username'])

src/Controller/Dashboard/DashboardPackagesController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
use CodedMonkey\Dirigent\Attribute\IsGrantedAccess;
88
use CodedMonkey\Dirigent\Attribute\MapPackage;
99
use CodedMonkey\Dirigent\Doctrine\Entity\Package;
10-
use CodedMonkey\Dirigent\Doctrine\Entity\PackageFetchStrategy;
1110
use CodedMonkey\Dirigent\Doctrine\Repository\PackageRepository;
1211
use CodedMonkey\Dirigent\EasyAdmin\PackagePaginator;
12+
use CodedMonkey\Dirigent\Entity\PackageFetchStrategy;
1313
use CodedMonkey\Dirigent\Entity\PackageUpdateSource;
1414
use CodedMonkey\Dirigent\Form\PackageAddMirroringFormType;
1515
use CodedMonkey\Dirigent\Form\PackageAddVcsFormType;

src/Controller/Dashboard/DashboardRegistryController.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
namespace CodedMonkey\Dirigent\Controller\Dashboard;
66

77
use CodedMonkey\Dirigent\Doctrine\Entity\Registry;
8-
use CodedMonkey\Dirigent\Doctrine\Entity\RegistryPackageMirroring;
98
use CodedMonkey\Dirigent\Doctrine\Repository\RegistryRepository;
109
use CodedMonkey\Dirigent\EasyAdmin\DateIntervalField;
10+
use CodedMonkey\Dirigent\Entity\RegistryPackageMirroring;
1111
use EasyCorp\Bundle\EasyAdminBundle\Attribute\AdminRoute;
1212
use EasyCorp\Bundle\EasyAdminBundle\Config\Action;
1313
use EasyCorp\Bundle\EasyAdminBundle\Config\Actions;
@@ -71,10 +71,8 @@ public function configureFields(string $pageName): iterable
7171

7272
yield ChoiceField::new('packageMirroring')
7373
->setSortable(false)
74-
->setTemplatePath('dashboard/fields/registry_package_mirroring.html.twig')
7574
->setRequired(true)
7675
->setChoices(RegistryPackageMirroring::cases())
77-
->setFormTypeOption('choice_label', static fn (RegistryPackageMirroring $choice): string => "registry.package-mirroring.{$choice->value}")
7876
->renderExpanded();
7977

8078
yield DateIntervalField::new('dynamicUpdateDelay')

src/Doctrine/DataFixtures/AppFixtures.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
namespace CodedMonkey\Dirigent\Doctrine\DataFixtures;
66

77
use CodedMonkey\Dirigent\Doctrine\Entity\Registry;
8-
use CodedMonkey\Dirigent\Doctrine\Entity\RegistryPackageMirroring;
98
use CodedMonkey\Dirigent\Doctrine\Entity\User;
9+
use CodedMonkey\Dirigent\Entity\RegistryPackageMirroring;
1010
use CodedMonkey\Dirigent\Entity\UserRole;
1111
use Doctrine\Bundle\FixturesBundle\Fixture;
1212
use Doctrine\Persistence\ObjectManager;

src/Doctrine/DataFixtures/PackageFixtures.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
namespace CodedMonkey\Dirigent\Doctrine\DataFixtures;
66

77
use CodedMonkey\Dirigent\Doctrine\Entity\Package;
8-
use CodedMonkey\Dirigent\Doctrine\Entity\PackageFetchStrategy;
8+
use CodedMonkey\Dirigent\Entity\PackageFetchStrategy;
99
use CodedMonkey\Dirigent\Package\PackageMetadataResolver;
1010
use Doctrine\Bundle\FixturesBundle\Fixture;
1111
use Doctrine\Persistence\ObjectManager;

src/Doctrine/Entity/Credentials.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
use CodedMonkey\Dirigent\Doctrine\Repository\CredentialsRepository;
88
use CodedMonkey\Dirigent\Doctrine\Type\EncryptedTextType;
9+
use CodedMonkey\Dirigent\Entity\CredentialsType;
910
use Doctrine\DBAL\Types\Types;
1011
use Doctrine\ORM\Mapping as ORM;
1112

@@ -25,7 +26,7 @@ class Credentials implements \Stringable
2526
private ?string $description = null;
2627

2728
#[ORM\Column(type: Types::STRING, enumType: CredentialsType::class)]
28-
private CredentialsType|string $type = CredentialsType::HttpBasic;
29+
private CredentialsType $type = CredentialsType::HttpBasic;
2930

3031
#[ORM\Column(type: EncryptedTextType::TYPE, nullable: true)]
3132
private ?string $username = null;
@@ -56,12 +57,12 @@ public function setDescription(?string $description): void
5657
$this->description = $description;
5758
}
5859

59-
public function getType(): CredentialsType|string
60+
public function getType(): CredentialsType
6061
{
6162
return $this->type;
6263
}
6364

64-
public function setType(CredentialsType|string $type): void
65+
public function setType(CredentialsType $type): void
6566
{
6667
$this->type = $type;
6768
}

src/Doctrine/Entity/CredentialsType.php

Lines changed: 0 additions & 13 deletions
This file was deleted.

src/Doctrine/Entity/Package.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
namespace CodedMonkey\Dirigent\Doctrine\Entity;
66

77
use CodedMonkey\Dirigent\Doctrine\Repository\PackageRepository;
8+
use CodedMonkey\Dirigent\Entity\PackageFetchStrategy;
89
use CodedMonkey\Dirigent\Package\PackageMetadataResolver;
910
use CodedMonkey\Dirigent\Validator\UniquePackage;
1011
use Composer\Package\Version\VersionParser;
@@ -65,7 +66,7 @@ class Package extends TrackedEntity
6566
private ?string $remoteId = null;
6667

6768
#[ORM\Column(nullable: true, enumType: PackageFetchStrategy::class)]
68-
private PackageFetchStrategy|string|null $fetchStrategy = null;
69+
private ?PackageFetchStrategy $fetchStrategy = null;
6970

7071
#[ORM\ManyToOne]
7172
private ?Registry $mirrorRegistry = null;
@@ -233,7 +234,7 @@ public function setRemoteId(?string $remoteId): void
233234
$this->remoteId = $remoteId;
234235
}
235236

236-
public function getFetchStrategy(): PackageFetchStrategy|string
237+
public function getFetchStrategy(): PackageFetchStrategy
237238
{
238239
if (!$this->fetchStrategy) {
239240
return $this->mirrorRegistry ? PackageFetchStrategy::Mirror : PackageFetchStrategy::Vcs;
@@ -242,7 +243,7 @@ public function getFetchStrategy(): PackageFetchStrategy|string
242243
return $this->fetchStrategy;
243244
}
244245

245-
public function setFetchStrategy(PackageFetchStrategy|string $fetchStrategy): void
246+
public function setFetchStrategy(PackageFetchStrategy $fetchStrategy): void
246247
{
247248
$this->fetchStrategy = $fetchStrategy;
248249
}

0 commit comments

Comments
 (0)