Create tests for MFA pages [temp]

Author: codedmonkey

src/Controller/Dashboard/DashboardAccountController.php

@@ -112,8 +112,6 @@ public function mfa(Request $request, #[CurrentUser] User $user): Response
             $totpCode = $form->get('totpCode')->getData();
 
             if (!$this->totpAuthenticator->checkCode($user, $totpCode)) {
-                $user->setTotpSecret(null);
-
                 $form->get('totpCode')->addError(new FormError('account.error.totp-incorrect'));
             }
 

src/Doctrine/Entity/User.php

@@ -189,6 +189,6 @@ public function getTotpAuthenticationUsername(): string
 
     public function getTotpAuthenticationConfiguration(): ?TotpConfigurationInterface
     {
-        return new TotpConfiguration($this->totpSecret, TotpConfiguration::ALGORITHM_SHA1, 30, 6);
+        return $this->totpSecret ? new TotpConfiguration($this->totpSecret, TotpConfiguration::ALGORITHM_SHA1, 30, 6) : null;
     }
 }

tests/FunctionalTests/Controller/Dashboard/DashboardAccountControllerTest.php

@@ -8,7 +8,6 @@
 use CodedMonkey\Dirigent\Tests\Helper\WebTestCaseTrait;
 use Doctrine\ORM\EntityManagerInterface;
 use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\RequiresFunction;
 use Scheb\TwoFactorBundle\Security\TwoFactor\Provider\Totp\TotpFactory;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 use Symfony\Component\HttpFoundation\Response;
@@ -28,7 +27,7 @@ public function testMfaUnauthenticated(): void
         $this->assertResponseRedirects('/login', Response::HTTP_FOUND);
     }
 
-    #[RequiresFunction('\Safe\unpack')] // todo test fails with Lowest Composer dependencies
+    // #[RequiresFunction('\Safe\unpack')] // todo test fails with Lowest Composer dependencies
     public function testMfaSetup(): void
     {
         $client = static::createClient();
@@ -48,9 +47,60 @@ public function testMfaSetup(): void
 
         $this->assertResponseRedirects('/account', Response::HTTP_FOUND);
 
+        $user = $this->getService(EntityManagerInterface::class)->find(User::class, $user->getId());
+
         $this->assertNotNull($user->getTotpSecret());
     }
 
+    public function testMfaSetupWrongPassword(): void
+    {
+        $client = static::createClient();
+        $totpFactory = $this->getService(TotpFactory::class, 'scheb_two_factor.security.totp_factory');
+
+        $user = $this->createMockUser();
+        $this->persistEntities($user);
+
+        $client->loginUser($user);
+
+        $client->request('GET', '/account/mfa');
+
+        $client->submitForm('Enable MFA authentication', [
+            'mfa_setup_form[currentPassword]' => 'OddPassword11',
+            'mfa_setup_form[totpCode]' => $totpFactory->createTotpForUser($user)->now(),
+        ]);
+
+        $this->assertResponseStatusCodeSame(Response::HTTP_UNPROCESSABLE_ENTITY);
+
+        $this->clearEntities();
+        $user = $this->getService(EntityManagerInterface::class)->find(User::class, $user->getId());
+
+        $this->assertNull($user->getTotpSecret());
+    }
+
+    public function testMfaSetupWrongTotpCode(): void
+    {
+        $client = static::createClient();
+
+        $user = $this->createMockUser();
+        $this->persistEntities($user);
+
+        $client->loginUser($user);
+
+        $client->request('GET', '/account/mfa');
+
+        $client->submitForm('Enable MFA authentication', [
+            'mfa_setup_form[currentPassword]' => 'PlainPassword99',
+            'mfa_setup_form[totpCode]' => 'abcdef',
+        ]);
+
+        $this->assertResponseStatusCodeSame(Response::HTTP_UNPROCESSABLE_ENTITY);
+
+        $this->clearEntities();
+        $user = $this->getService(EntityManagerInterface::class)->find(User::class, $user->getId());
+
+        $this->assertNull($user->getTotpSecret());
+    }
+
     public function testMfaClear(): void
     {
         $client = static::createClient();
@@ -73,6 +123,28 @@ public function testMfaClear(): void
         $this->assertNull($user->getTotpSecret());
     }
 
+    public function testMfaClearWrongPassword(): void
+    {
+        $client = static::createClient();
+
+        $user = $this->createMockUser(mfaEnabled: true);
+        $this->persistEntities($user);
+
+        $client->loginUser($user);
+
+        $client->request('GET', '/account/mfa');
+
+        $client->submitForm('Disable MFA authentication', [
+            'mfa_clear_form[currentPassword]' => 'OddPassword11',
+        ]);
+
+        $this->assertResponseStatusCodeSame(Response::HTTP_UNPROCESSABLE_ENTITY);
+
+        $user = $this->getService(EntityManagerInterface::class)->find(User::class, $user->getId());
+
+        $this->assertNotNull($user->getTotpSecret());
+    }
+
     public function testMfaQrCodeUnauthenticated(): void
     {
         $client = static::createClient();

tests/Helper/MockEntityFactoryTrait.php

@@ -65,10 +65,10 @@ protected function persistEntities(...$entities): void
         $entityManager->flush();
     }
 
-    protected function refreshEntity(object $entity): void
+    protected function clearEntities(): void
     {
         $entityManager = $this->getService(EntityManagerInterface::class);
 
-        $entityManager->refresh($entity);
+        $entityManager->clear();
     }
 }