Refactor package version info route

Author: codedmonkey

src/Controller/Dashboard/DashboardPackagesController.php

@@ -57,26 +57,28 @@ public function list(Request $request): Response
         ]);
     }
 
-    #[Route('/packages/{packageName}/{packageVersion}', name: 'dashboard_packages_info', requirements: ['packageName' => '[a-z0-9_.-]+/[a-z0-9_.-]+'])]
+    #[Route('/packages/{packageName}', name: 'dashboard_packages_info', requirements: ['packageName' => '[a-z0-9_.-]+/[a-z0-9_.-]+'])]
     #[IsGrantedAccess]
-    public function info(string $packageName, ?string $packageVersion = null): Response
+    public function info(string $packageName): Response
     {
         $package = $this->packageRepository->findOneBy(['name' => $packageName]);
+        $version = $package->getLatestVersion();
 
-        $versions = $package->getVersions()->toArray();
-        $latestVersion = $package->getDefaultVersion();
-
-        usort($versions, Package::class . '::sortVersions');
+        return $this->render('dashboard/packages/package_info.html.twig', [
+            'package' => $package,
+            'version' => $version,
+        ]);
+    }
 
-        if (null !== $packageVersion) {
-            $version = $package->getVersion((new VersionParser())->normalize($packageVersion));
-        } else {
-            $version = $package->getLatestVersion();
-        }
+    #[Route('/packages/{packageName}/v/{packageVersion}', name: 'dashboard_packages_version_info', requirements: ['packageName' => '[a-z0-9_.-]+/[a-z0-9_.-]+'])]
+    #[IsGrantedAccess]
+    public function versionInfo(string $packageName, string $packageVersion): Response
+    {
+        $package = $this->packageRepository->findOneBy(['name' => $packageName]);
+        $version = $package->getVersion((new VersionParser())->normalize($packageVersion));
 
         return $this->render('dashboard/packages/package_info.html.twig', [
             'package' => $package,
-            'latestVersion' => $latestVersion,
             'version' => $version,
         ]);
     }

templates/dashboard/packages/package_versions.html.twig

@@ -7,7 +7,7 @@
 
   <div class="list-group list-group-flush mb-3">
     {% for version in versions %}
-      {% set packageVersionInfoUrl = path('dashboard_packages_info', {packageName: package.name, packageVersion: version.version}) %}
+      {% set packageVersionInfoUrl = path('dashboard_packages_version_info', {packageName: package.name, packageVersion: version.version}) %}
       <a href="{{ packageVersionInfoUrl }}" class="list-group-item">
         <div class="d-flex justify-content-between">
           <span>