Create trait to simplify authentication in tests

Author: codedmonkey

tests/FunctionalTests/DashboardPackagesControllerTest.php

@@ -2,23 +2,17 @@
 
 namespace CodedMonkey\Dirigent\Tests\FunctionalTests;
 
-use CodedMonkey\Dirigent\Doctrine\Entity\User;
 use CodedMonkey\Dirigent\Doctrine\Repository\PackageRepository;
-use CodedMonkey\Dirigent\Doctrine\Repository\UserRepository;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 
 class DashboardPackagesControllerTest extends WebTestCase
 {
+    use WebTestCaseTrait;
+
     public function testStatistics(): void
     {
         $client = static::createClient();
-
-        /** @var UserRepository $userRepository */
-        $userRepository = $client->getContainer()->get(UserRepository::class);
-
-        /** @var User $user */
-        $user = $userRepository->findOneByUsername('user');
-        $client->loginUser($user);
+        $this->loginUser();
 
         $client->request('GET', '/?routeName=dashboard_packages_statistics&routeParams[packageName]=psr/log');
 
@@ -38,13 +32,7 @@ public function testStatistics(): void
     public function testAddVcsRepository(): void
     {
         $client = static::createClient();
-
-        /** @var UserRepository $userRepository */
-        $userRepository = $client->getContainer()->get(UserRepository::class);
-
-        /** @var User $user */
-        $user = $userRepository->findOneByUsername('owner');
-        $client->loginUser($user);
+        $this->loginUser('admin');
 
         $client->request('GET', '/?routeName=dashboard_packages_add_vcs');
         $client->submitForm('Add VCS repository', [
@@ -65,13 +53,7 @@ public function testAddVcsRepository(): void
     public function testEdit(): void
     {
         $client = static::createClient();
-
-        /** @var UserRepository $userRepository */
-        $userRepository = $client->getContainer()->get(UserRepository::class);
-
-        /** @var User $user */
-        $user = $userRepository->findOneByUsername('owner');
-        $client->loginUser($user);
+        $this->loginUser('admin');
 
         $client->request('GET', '/?routeName=dashboard_packages_edit&routeParams[packageName]=psr/log');
         $client->submitForm('Save changes');

tests/FunctionalTests/DashboardRootControllerTest.php

@@ -2,22 +2,16 @@
 
 namespace CodedMonkey\Dirigent\Tests\FunctionalTests;
 
-use CodedMonkey\Dirigent\Doctrine\Entity\User;
-use CodedMonkey\Dirigent\Doctrine\Repository\UserRepository;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 
 class DashboardRootControllerTest extends WebTestCase
 {
+    use WebTestCaseTrait;
+
     public function testIndex(): void
     {
         $client = static::createClient();
-
-        /** @var UserRepository $userRepository */
-        $userRepository = $client->getContainer()->get(UserRepository::class);
-
-        /** @var User $user */
-        $user = $userRepository->findOneByUsername('user');
-        $client->loginUser($user);
+        $this->loginUser();
 
         $client->request('GET', '/');
 

tests/FunctionalTests/WebTestCaseTrait.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace CodedMonkey\Dirigent\Tests\FunctionalTests;
+
+use CodedMonkey\Dirigent\Doctrine\Entity\User;
+use CodedMonkey\Dirigent\Doctrine\Repository\UserRepository;
+
+trait WebTestCaseTrait
+{
+    protected function loginUser(string $username = 'user'): User
+    {
+        $client = static::getClient();
+        /** @var UserRepository $userRepository */
+        $userRepository = $client->getContainer()->get(UserRepository::class);
+
+        /** @var User $user */
+        $user = $userRepository->findOneByUsername($username);
+        $client->loginUser($user);
+
+        return $user;
+    }
+}