Create default_fetch_strategy configuration option

Author: codedmonkey

docs/configuration-reference.md

@@ -37,7 +37,7 @@ dirigent:
     dev_packages: false
     preferred_mirror: true
   metadata:
-    mirror_vcs_repositories: false
+    default_fetch_strategy: 'mirror'
 ```
 
 ## dirigent (root)
@@ -136,9 +136,11 @@ Enable building distribution from the source.
 
 ## metadata
 
-### mirror_vcs_repositories
+### default_fetch_strategy
 
-Type: `boolean` | Default: `false`
+Type: `string` | Default: `mirror`
+
+todo
 
 Fetch mirrored packages from their VCS repositories by default when possible.
 

src/Controller/ApiController.php

@@ -41,8 +41,8 @@ public function __construct(
         private readonly MessageBusInterface $messenger,
         #[Autowire(param: 'dirigent.packages.dynamic_updates')]
         private readonly bool $dynamicUpdatesEnabled,
-        #[Autowire(param: 'dirigent.metadata.mirror_vcs_repositories')]
-        private readonly bool $mirrorVcsRepositories = false,
+        #[Autowire(param: 'dirigent.metadata.default_fetch_strategy')]
+        private readonly PackageFetchStrategy $defaultFetchStrategy,
     ) {
     }
 
@@ -183,7 +183,7 @@ private function findPackage(string $packageName, ?bool $create = false): ?Packa
                 $package = new Package();
                 $package->setName($packageName);
                 $package->setMirrorRegistry($registry);
-                $package->setFetchStrategy($this->mirrorVcsRepositories ? PackageFetchStrategy::Vcs : PackageFetchStrategy::Mirror);
+                $package->setFetchStrategy($this->defaultFetchStrategy);
 
                 $this->packageRepository->save($package, true);
             }

src/Controller/Dashboard/DashboardPackagesController.php

@@ -30,8 +30,8 @@ public function __construct(
         private readonly PackageRepository $packageRepository,
         private readonly PackageMetadataResolver $metadataResolver,
         private readonly MessageBusInterface $messenger,
-        #[Autowire(param: 'dirigent.metadata.mirror_vcs_repositories')]
-        private readonly bool $mirrorVcsRepositories = false,
+        #[Autowire(param: 'dirigent.metadata.default_fetch_strategy')]
+        private readonly PackageFetchStrategy $defaultFetchStrategy,
     ) {
     }
 
@@ -109,7 +109,7 @@ public function addMirroring(Request $request): Response
                 $package = new Package();
                 $package->setName($packageName);
                 $package->setMirrorRegistry($registry);
-                $package->setFetchStrategy($this->mirrorVcsRepositories ? PackageFetchStrategy::Vcs : PackageFetchStrategy::Mirror);
+                $package->setFetchStrategy($this->defaultFetchStrategy);
 
                 $this->packageRepository->save($package, true);
 
@@ -147,6 +147,11 @@ public function addVcsRepository(Request $request): Response
         if ($form->isSubmitted() && $form->isValid()) {
             /** @var Package $package */
             $package = $form->getData();
+
+            // Mirroring is not possible for local packages
+            $defaultFetchStrategy = $this->defaultFetchStrategy->isMirror() ? PackageFetchStrategy::Source : $this->defaultFetchStrategy;
+            $package->setFetchStrategy($defaultFetchStrategy);
+
             $this->packageRepository->save($package, true);
 
             $this->messenger->dispatch(new UpdatePackage($package->getId(), PackageUpdateSource::Manual));

src/DependencyInjection/DirigentConfiguration.php

@@ -2,6 +2,7 @@
 
 namespace CodedMonkey\Dirigent\DependencyInjection;
 
+use CodedMonkey\Dirigent\Doctrine\Entity\PackageFetchStrategy;
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
 use Symfony\Component\Config\Definition\Builder\NodeDefinition;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
@@ -83,7 +84,7 @@ private function addDistributionsSection(ArrayNodeDefinition|NodeDefinition $roo
             ->arrayNode('distributions')
                 ->canBeEnabled('Host the distributions of packages')
                 ->children()
-                    ->booleanNode('build')->defaultTrue()->info('Build distributions from the source code (if not already provided)')->end()
+                    ->booleanNode('build')->defaultTrue()->info('Build distributions from the source code (if available)')->end()
                     ->booleanNode('mirror')->defaultFalse()->info('Mirror distributions from the original source (if provided)')->end()
                     ->booleanNode('async_api_requests')->defaultFalse()->info('Fetch distributions asynchronously instead of during execution (from the API)')->end()
                     ->booleanNode('dev_versions')->defaultFalse()->info('Include distributions of development versions')->end()
@@ -98,9 +99,10 @@ private function addMetadataSection(ArrayNodeDefinition|NodeDefinition $rootNode
             ->arrayNode('metadata')
                 ->addDefaultsIfNotSet()
                 ->children()
-                    ->booleanNode('mirror_vcs_repositories')
-                        ->defaultFalse()
-                        ->info('Fetch mirrored packages from their VCS repositories by default when possible.')
+                    ->enumNode('default_fetch_strategy')
+                        ->enumFqcn(PackageFetchStrategy::class)
+                        ->defaultValue(PackageFetchStrategy::Mirror)
+                        ->info('Available values are "mirror" (default, fetch from the mirror), "source" (fetch from the VCS source) and "vcs" (fetch complete VCS repository)')
                     ->end()
                 ->end()
             ->end();

src/DependencyInjection/DirigentExtension.php

@@ -2,6 +2,7 @@
 
 namespace CodedMonkey\Dirigent\DependencyInjection;
 
+use CodedMonkey\Dirigent\Doctrine\Entity\PackageFetchStrategy;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\DependencyInjection\ConfigurableExtension;
@@ -65,11 +66,11 @@ private function registerEncryptionConfiguration(array $config, ContainerBuilder
     }
 
     /**
-     * @param array{mirror_vcs_repositories: bool} $config
+     * @param array{default_fetch_strategy: PackageFetchStrategy} $config
      */
     private function registerMetadataConfiguration(array $config, ContainerBuilder $container): void
     {
-        $container->setParameter('dirigent.metadata.mirror_vcs_repositories', $config['mirror_vcs_repositories']);
+        $container->setParameter('dirigent.metadata.default_fetch_strategy', $config['default_fetch_strategy']);
     }
 
     /**