Refactor CredentialsType enum

Author: codedmonkey

src/Composer/ConfigFactory.php

@@ -5,8 +5,8 @@
 namespace CodedMonkey\Dirigent\Composer;
 
 use CodedMonkey\Dirigent\Doctrine\Entity\Credentials;
-use CodedMonkey\Dirigent\Doctrine\Entity\CredentialsType;
 use CodedMonkey\Dirigent\Doctrine\Entity\Registry;
+use CodedMonkey\Dirigent\Entity\CredentialsType;
 use Composer\Config;
 use Composer\Factory;
 

src/Controller/Dashboard/DashboardCredentialsController.php

@@ -5,7 +5,7 @@
 namespace CodedMonkey\Dirigent\Controller\Dashboard;
 
 use CodedMonkey\Dirigent\Doctrine\Entity\Credentials;
-use CodedMonkey\Dirigent\Doctrine\Entity\CredentialsType;
+use CodedMonkey\Dirigent\Entity\CredentialsType;
 use EasyCorp\Bundle\EasyAdminBundle\Attribute\AdminRoute;
 use EasyCorp\Bundle\EasyAdminBundle\Config\Crud;
 use EasyCorp\Bundle\EasyAdminBundle\Controller\AbstractCrudController;
@@ -37,10 +37,8 @@ public function configureFields(string $pageName): iterable
         yield TextareaField::new('description')
             ->onlyOnForms();
         yield ChoiceField::new('type')
-            ->setTemplatePath('dashboard/fields/credentials_type.html.twig')
             ->setRequired(true)
             ->setChoices(CredentialsType::cases())
-            ->setFormTypeOption('choice_label', static fn (CredentialsType $choice): string => "credentials.type.{$choice->value}")
             ->renderExpanded();
         yield TextField::new('username')
             ->setFormTypeOption('row_attr', ['data-credentials-field' => 'username'])

src/Doctrine/Entity/Credentials.php

@@ -6,6 +6,7 @@
 
 use CodedMonkey\Dirigent\Doctrine\Repository\CredentialsRepository;
 use CodedMonkey\Dirigent\Doctrine\Type\EncryptedTextType;
+use CodedMonkey\Dirigent\Entity\CredentialsType;
 use Doctrine\DBAL\Types\Types;
 use Doctrine\ORM\Mapping as ORM;
 
@@ -25,7 +26,7 @@ class Credentials implements \Stringable
     private ?string $description = null;
 
     #[ORM\Column(type: Types::STRING, enumType: CredentialsType::class)]
-    private CredentialsType|string $type = CredentialsType::HttpBasic;
+    private CredentialsType $type = CredentialsType::HttpBasic;
 
     #[ORM\Column(type: EncryptedTextType::TYPE, nullable: true)]
     private ?string $username = null;
@@ -56,12 +57,12 @@ public function setDescription(?string $description): void
         $this->description = $description;
     }
 
-    public function getType(): CredentialsType|string
+    public function getType(): CredentialsType
     {
         return $this->type;
     }
 
-    public function setType(CredentialsType|string $type): void
+    public function setType(CredentialsType $type): void
     {
         $this->type = $type;
     }

src/Doctrine/Entity/CredentialsType.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace CodedMonkey\Dirigent\Entity;
+
+use Symfony\Contracts\Translation\TranslatableInterface;
+use Symfony\Contracts\Translation\TranslatorInterface;
+
+enum CredentialsType: string implements TranslatableInterface
+{
+    case HttpBasic = 'http-basic';
+    case GithubOauthToken = 'github-oauth';
+    case GitlabDeployToken = 'gitlab-dt';
+    case GitlabPersonalAccessToken = 'gitlab-pat';
+
+    public function trans(TranslatorInterface $translator, ?string $locale = null): string
+    {
+        return $translator->trans("credentials.type.$this->value");
+    }
+}

src/Entity/CredentialsType.php

@@ -6,7 +6,7 @@
 
 use CodedMonkey\Dirigent\Controller\Dashboard\DashboardCredentialsController;
 use CodedMonkey\Dirigent\Doctrine\Entity\Credentials;
-use CodedMonkey\Dirigent\Doctrine\Entity\CredentialsType;
+use CodedMonkey\Dirigent\Entity\CredentialsType;
 use CodedMonkey\Dirigent\Tests\Helper\EntityManagerTestTrait;
 use CodedMonkey\Dirigent\Tests\Helper\MockEntityFactoryTrait;
 use CodedMonkey\Dirigent\Tests\Helper\WebTestCaseTrait;