Skip to content

Commit e64120f

Browse files
committed
Fix Doctrine deprecation: Specifying the "nullable" attribute for join columns in to-one associations that are part of the identifier is a no-op.
1 parent 792f956 commit e64120f

4 files changed

Lines changed: 28 additions & 3 deletions

File tree

src/Controller/Dashboard/DashboardPackagesInfoController.php

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,31 @@ public function versions(#[MapPackage] Package $package): Response
7676
]);
7777
}
7878

79+
#[Route('/packages/{package}/revisions/{version}', name: 'dashboard_packages_version_revisions', requirements: ['package' => MapPackage::PACKAGE_REGEX, 'version' => '.*'])]
80+
#[IsGrantedAccess]
81+
public function versionInfo(#[MapPackage] Package $package, #[MapPackage] Version $version): Response
82+
{
83+
/** @var MetadataRepository $metadataRepository */
84+
$metadataRepository = $this->entityManager->getRepository(Metadata::class);
85+
$metadataRepository->fetchMetadataCollections($version->getCurrentMetadata());
86+
87+
$dependentCount = $this->entityManager->getRepository(PackageRequireLink::class)->count(['linkedPackageName' => $package->getName()]);
88+
$implementationCount = $this->entityManager->getRepository(PackageProvideLink::class)->count(['linkedPackageName' => $package->getName(), 'implementation' => true]);
89+
$providerCount = $this->entityManager->getRepository(PackageProvideLink::class)->count(['linkedPackageName' => $package->getName(), 'implementation' => false]);
90+
$suggesterCount = $this->entityManager->getRepository(PackageSuggestLink::class)->count(['linkedPackageName' => $package->getName()]);
91+
92+
return $this->render('dashboard/packages/package_info.html.twig', [
93+
'package' => $package,
94+
'version' => $version,
95+
'metadata' => $version->getCurrentMetadata(),
96+
97+
'dependentCount' => $dependentCount,
98+
'implementationCount' => $implementationCount,
99+
'providerCount' => $providerCount,
100+
'suggesterCount' => $suggesterCount,
101+
]);
102+
}
103+
79104
#[Route('/packages/{package}/dependents', name: 'dashboard_packages_dependents', requirements: ['package' => MapPackage::PACKAGE_REGEX])]
80105
#[IsGrantedAccess]
81106
public function dependents(Request $request, #[MapPackage] Package $package): Response

src/Doctrine/Entity/PackageProvideLink.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#[ORM\Entity]
88
class PackageProvideLink extends AbstractPackageLink
99
{
10-
#[ORM\Id, ORM\ManyToOne(targetEntity: Package::class), ORM\JoinColumn(nullable: false)]
10+
#[ORM\Id, ORM\ManyToOne(targetEntity: Package::class)]
1111
protected Package $package;
1212

1313
#[ORM\Id, ORM\Column]

src/Doctrine/Entity/PackageRequireLink.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#[ORM\Entity]
88
class PackageRequireLink extends AbstractPackageLink
99
{
10-
#[ORM\Id, ORM\ManyToOne(targetEntity: Package::class), ORM\JoinColumn(nullable: false)]
10+
#[ORM\Id, ORM\ManyToOne(targetEntity: Package::class)]
1111
protected Package $package;
1212

1313
#[ORM\Id, ORM\Column]

src/Doctrine/Entity/PackageSuggestLink.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
#[ORM\Entity]
88
class PackageSuggestLink extends AbstractPackageLink
99
{
10-
#[ORM\Id, ORM\ManyToOne(targetEntity: Package::class), ORM\JoinColumn(nullable: false)]
10+
#[ORM\Id, ORM\ManyToOne(targetEntity: Package::class)]
1111
protected Package $package;
1212
}

0 commit comments

Comments
 (0)