Code style fixes

Author: codedmonkey

.dockerignore

@@ -1,5 +1,6 @@
 /.github/
 /.idea/
+/.phpunit.cache/
 /config/dirigent.json
 /config/dirigent.php
 /config/dirigent.yaml

.gitattributes

@@ -1,6 +1,6 @@
 # Documentation files
 docs/** linguist-documentation
-changelogd.md linguist-documentation
+changelog.md linguist-documentation
 license.md linguist-documentation
 readme.md linguist-documentation
 

phpstan.dist.neon

@@ -3,11 +3,16 @@ parameters:
     paths:
         - bin/
         - config/
+        - migrations/
         - public/
         - src/
         - tests/
     excludePaths:
         - tests/bootstrap.php
     ignoreErrors:
-        - '#Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition::children\(\).#'
-        - '#Property CodedMonkey\\Dirigent\\Doctrine\\Entity\\[a-zA-Z]+::\$id \(int\|null\) is never assigned int so it can be removed from the property type.#'
+        - '#^Property CodedMonkey\\Dirigent\\Doctrine\\Entity\\[a-zA-Z]+\:\:\$id \(int\|null\) is never assigned int so it can be removed from the property type\.$#'
+        -
+            message: '#^Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition\:\:children\(\)\.$#'
+            identifier: method.notFound
+            count: 1
+            path: src/DependencyInjection/DirigentConfiguration.php

src/EventListener/DashboardRoutingListener.php

@@ -19,7 +19,7 @@ public function __construct(
     }
 
     #[AsEventListener]
-    public function onKernelRequest(RequestEvent $event): void
+    public function redirectPrettyDashboardUrls(RequestEvent $event): void
     {
         $request = $event->getRequest();
 

…/EventListener/SecurityEventListener.php src/EventListener/SecurityListener.phpsrc/EventListener/SecurityEventListener.php renamed to src/EventListener/SecurityListener.php src/EventListener/SecurityEventListener.php renamed to src/EventListener/SecurityListener.php

@@ -13,7 +13,7 @@
 use Symfony\Component\Security\Http\Authenticator\Passport\Credentials\PasswordCredentials;
 use Symfony\Component\Security\Http\Event\CheckPassportEvent;
 
-readonly class SecurityEventListener
+readonly class SecurityListener
 {
     public function __construct(
         private AccessTokenRepository $accessTokenRepository,

src/Kernel.php

@@ -27,16 +27,17 @@ protected function configureContainer(ContainerConfigurator $container): void
         }
     }
 
+    protected function build(ContainerBuilder $container): void
+    {
+        $container->registerExtension(new DirigentExtension());
+    }
+
     public function boot(): void
     {
         parent::boot();
 
+        // Set Composer env vars
         $_SERVER['COMPOSER_CACHE_DIR'] = $this->container->getParameter('dirigent.storage.path') . '/composer-cache';
         $_SERVER['COMPOSER_HOME'] = $this->container->getParameter('dirigent.storage.path') . '/composer';
     }
-
-    protected function build(ContainerBuilder $container): void
-    {
-        $container->registerExtension(new DirigentExtension());
-    }
 }

src/Package/PackageMetadataResolver.php

@@ -403,8 +403,8 @@ private function updateReadme(Version $version, VcsDriverInterface $driver): voi
 
                     break;
             }
-        } catch (\Exception $e) {
-            throw $e; // todo handle politely
+        } catch (\Exception $exception) {
+            throw $exception; // todo handle politely
         }
     }
 

src/Package/PackageVcsRepositoryValidator.php

@@ -67,8 +67,8 @@ public function validate(Package $package): array
             }
 
             return $result;
-        } catch (\Exception $e) {
-            return ['error' => '[' . $e::class . '] ' . $e->getMessage()];
+        } catch (\Exception $exception) {
+            return ['error' => '[' . $exception::class . '] ' . $exception->getMessage()];
         }
     }
 

tests/FunctionalTests/DashboardPackagesControllerTest.php

@@ -45,7 +45,7 @@ public function testAddVcsRepository(): void
         $packageRepository = $client->getContainer()->get(PackageRepository::class);
 
         $package = $packageRepository->findOneByName('psr/container');
-        self::assertNotNull($package, 'A package was created');
+        self::assertNotNull($package, 'A package was created.');
 
         $packageRepository->remove($package, true);
     }