Add mirror_vcs_repositories configuration option

Author: codedmonkey

phpstan.dist.neon

@@ -10,14 +10,10 @@ parameters:
     excludePaths:
         - tests/bootstrap.php
     ignoreErrors:
+        - '#^Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition\:\:children\(\)\.$#'
         - '#CodedMonkey\\Dirigent\\Doctrine\\Entity\\AbstractVersionLink given\.#'
         - '#^PHPDoc tag @var with type CodedMonkey\\Dirigent\\Doctrine\\Entity\\AbstractVersionLink is not subtype of native type#'
         - '#^Property CodedMonkey\\Dirigent\\Doctrine\\Entity\\[a-zA-Z]+\:\:\$id \(int\|null\) is never assigned int so it can be removed from the property type\.$#'
-        -
-            message: '#^Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition\:\:children\(\)\.$#'
-            identifier: method.notFound
-            count: 1
-            path: src/DependencyInjection/DirigentConfiguration.php
         -
             message: '#^Left side of \|\| is always false\.$#'
             identifier: booleanOr.leftAlwaysFalse

src/Controller/ApiController.php

@@ -13,6 +13,7 @@
 use CodedMonkey\Dirigent\Package\PackageMetadataResolver;
 use CodedMonkey\Dirigent\Package\PackageProviderManager;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\DependencyInjection\Attribute\Autowire;
 use Symfony\Component\HttpFoundation\BinaryFileResponse;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
@@ -33,6 +34,8 @@ public function __construct(
         private readonly PackageDistributionResolver $distributionResolver,
         private readonly PackageProviderManager $providerManager,
         private readonly MessageBusInterface $messenger,
+        #[Autowire(param: 'dirigent.metadata.mirror_vcs_repositories')]
+        private readonly bool $mirrorVcsRepositories = false,
     ) {
     }
 
@@ -170,7 +173,7 @@ private function findPackage(string $packageName): ?Package
         $package = new Package();
         $package->setName($packageName);
         $package->setMirrorRegistry($registry);
-        $package->setFetchStrategy(PackageFetchStrategy::Mirror);
+        $package->setFetchStrategy($this->mirrorVcsRepositories ? PackageFetchStrategy::Vcs : PackageFetchStrategy::Mirror);
 
         $this->packageRepository->save($package, true);
 

src/Controller/Dashboard/DashboardPackagesController.php

@@ -14,6 +14,7 @@
 use CodedMonkey\Dirigent\Package\PackageMetadataResolver;
 use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\DependencyInjection\Attribute\Autowire;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Messenger\MessageBusInterface;
@@ -27,6 +28,8 @@ public function __construct(
         private readonly PackageRepository $packageRepository,
         private readonly PackageMetadataResolver $metadataResolver,
         private readonly MessageBusInterface $messenger,
+        #[Autowire(param: 'dirigent.metadata.mirror_vcs_repositories')]
+        private readonly bool $mirrorVcsRepositories = false,
     ) {
     }
 
@@ -104,7 +107,7 @@ public function addMirroring(Request $request): Response
                 $package = new Package();
                 $package->setName($packageName);
                 $package->setMirrorRegistry($registry);
-                $package->setFetchStrategy(PackageFetchStrategy::Mirror);
+                $package->setFetchStrategy($this->mirrorVcsRepositories ? PackageFetchStrategy::Vcs : PackageFetchStrategy::Mirror);
 
                 $this->packageRepository->save($package, true);
 

src/DependencyInjection/DirigentConfiguration.php

@@ -2,6 +2,8 @@
 
 namespace CodedMonkey\Dirigent\DependencyInjection;
 
+use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
+use Symfony\Component\Config\Definition\Builder\NodeDefinition;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 use function Symfony\Component\String\u;
@@ -84,6 +86,22 @@ public function getConfigTreeBuilder(): TreeBuilder
                 ->end()
             ->end();
 
+        $this->addMetadataSection($rootNode);
+
         return $treeBuilder;
     }
+
+    private function addMetadataSection(ArrayNodeDefinition|NodeDefinition $rootNode): void
+    {
+        $rootNode->children()
+            ->arrayNode('metadata')
+                ->addDefaultsIfNotSet()
+                ->children()
+                    ->booleanNode('mirror_vcs_repositories')
+                        ->defaultFalse()
+                        ->info('Fetch mirrored packages from their VCS repositories by default when possible.')
+                    ->end()
+                ->end()
+            ->end();
+    }
 }

src/DependencyInjection/DirigentExtension.php

@@ -12,14 +12,14 @@ class DirigentExtension extends ConfigurableExtension
     protected function loadInternal(array $mergedConfig, ContainerBuilder $container): void
     {
         if (null === $slug = $mergedConfig['slug']) {
-            $slug = (new AsciiSlugger())->slug($mergedConfig['title']);
-            $slug = strtolower($slug);
+            $slug = (new AsciiSlugger())->slug($mergedConfig['title'])->lower();
         }
 
         $container->setParameter('dirigent.title', $mergedConfig['title']);
         $container->setParameter('dirigent.slug', $slug);
 
         $this->registerEncryptionConfiguration($mergedConfig['encryption'], $container);
+        $this->registerMetadataConfiguration($mergedConfig['metadata'], $container);
 
         $container->setParameter('dirigent.security.public_access', $mergedConfig['security']['public']);
         $container->setParameter('dirigent.security.registration_enabled', $mergedConfig['security']['registration']);
@@ -58,4 +58,12 @@ private function registerEncryptionConfiguration(array $config, ContainerBuilder
         $container->setParameter('dirigent.encryption.public_key_path', $config['public_key_path']);
         $container->setParameter('dirigent.encryption.rotated_key_paths', $config['rotated_key_paths']);
     }
+
+    /**
+     * @param array{mirror_vcs_repositories: bool} $config
+     */
+    private function registerMetadataConfiguration(array $config, ContainerBuilder $container): void
+    {
+        $container->setParameter('dirigent.metadata.mirror_vcs_repositories', $config['mirror_vcs_repositories']);
+    }
 }