Code style fixes in functional tests

Author: codedmonkey

tests/FunctionalTests/Controller/Dashboard/DashboardPackagesControllerTest.php

@@ -24,12 +24,15 @@ public function testAddMirroring(): void
         $registry = $client->getContainer()->get(RegistryRepository::class)->findOneBy(['name' => 'Packagist']);
 
         $client->request('GET', '/packages/add-mirroring');
+
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
+
         $client->submitForm('Add packages', [
             'package_add_mirroring_form[packages]' => 'psr/cache',
             'package_add_mirroring_form[registry]' => $registry->getId(),
         ]);
 
-        $this->assertResponseStatusCodeSame(200);
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
 
         // todo the submit request should be invoked with ajax, and this assertion should be performed on the initial request
         // however, the assertion is performed on the ajax response making it invalid
@@ -54,11 +57,14 @@ public function testAddVcsRepository(): void
         $this->loginUser('admin');
 
         $client->request('GET', '/packages/add-vcs');
+
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
+
         $client->submitForm('Add VCS repository', [
             'package_add_vcs_form[repositoryUrl]' => 'https://github.com/php-fig/container',
         ]);
 
-        $this->assertResponseStatusCodeSame(302);
+        $this->assertResponseStatusCodeSame(Response::HTTP_FOUND);
 
         /** @var PackageRepository $packageRepository */
         $packageRepository = $client->getContainer()->get(PackageRepository::class);
@@ -75,9 +81,12 @@ public function testEdit(): void
         $this->loginUser('admin');
 
         $client->request('GET', '/packages/psr/log/edit');
+
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
+
         $client->submitForm('Save changes');
 
-        $this->assertResponseStatusCodeSame(302);
+        $this->assertResponseStatusCodeSame(Response::HTTP_FOUND);
     }
 
     public function testDelete(): void

tests/FunctionalTests/Controller/Dashboard/DashboardPackagesInfoControllerTest.php

@@ -7,6 +7,7 @@
 use CodedMonkey\Dirigent\Doctrine\Repository\UserRepository;
 use CodedMonkey\Dirigent\Tests\FunctionalTests\WebTestCaseTrait;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+use Symfony\Component\HttpFoundation\Response;
 
 class DashboardPackagesInfoControllerTest extends WebTestCase
 {
@@ -19,7 +20,7 @@ public function testInfo(): void
 
         $client->request('GET', '/packages/psr/log');
 
-        $this->assertResponseStatusCodeSame(200);
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
     }
 
     public function testPackageInfo(): void
@@ -29,7 +30,7 @@ public function testPackageInfo(): void
 
         $client->request('GET', '/packages/psr/log/v/1.0.0');
 
-        $this->assertResponseStatusCodeSame(200);
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
     }
 
     public function testVersions(): void
@@ -39,7 +40,7 @@ public function testVersions(): void
 
         $client->request('GET', '/packages/psr/log/versions');
 
-        $this->assertResponseStatusCodeSame(200);
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
     }
 
     public function testDependents(): void
@@ -55,7 +56,7 @@ public function testDependents(): void
 
         $client->request('GET', '/packages/psr/log/dependents');
 
-        $this->assertResponseStatusCodeSame(200);
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
 
         $this->assertAnySelectorTextSame('h1 small', 'Dependents');
     }
@@ -73,7 +74,7 @@ public function testImplementations(): void
 
         $client->request('GET', '/packages/psr/log/implementations');
 
-        $this->assertResponseStatusCodeSame(200);
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
 
         $this->assertAnySelectorTextSame('h1 small', 'Implementations');
     }
@@ -91,7 +92,7 @@ public function testProviders(): void
 
         $client->request('GET', '/packages/psr/log/providers');
 
-        $this->assertResponseStatusCodeSame(200);
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
 
         $this->assertAnySelectorTextSame('h1 small', 'Providers');
     }
@@ -109,7 +110,7 @@ public function testSuggesters(): void
 
         $client->request('GET', '/packages/psr/log/suggesters');
 
-        $this->assertResponseStatusCodeSame(200);
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
 
         $this->assertAnySelectorTextSame('h1 small', 'Suggesters');
     }
@@ -121,7 +122,7 @@ public function testStatistics(): void
 
         $client->request('GET', '/packages/psr/log/statistics');
 
-        $this->assertResponseStatusCodeSame(200);
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
 
         /** @var PackageRepository $packageRepository */
         $packageRepository = $client->getContainer()->get(PackageRepository::class);

tests/FunctionalTests/Controller/Dashboard/DashboardRootControllerPublicTest.php

@@ -4,6 +4,7 @@
 
 use CodedMonkey\Dirigent\Tests\FunctionalTests\PublicKernel;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+use Symfony\Component\HttpFoundation\Response;
 
 class DashboardRootControllerPublicTest extends WebTestCase
 {
@@ -18,7 +19,7 @@ public function testIndex(): void
 
         $client->request('GET', '/');
 
-        $this->assertResponseStatusCodeSame(200);
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
 
         $this->assertAnySelectorTextSame('#total_packages .display-6', '1');
     }

tests/FunctionalTests/Controller/Dashboard/DashboardRootControllerTest.php

@@ -5,6 +5,7 @@
 use CodedMonkey\Dirigent\Kernel;
 use CodedMonkey\Dirigent\Tests\FunctionalTests\WebTestCaseTrait;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+use Symfony\Component\HttpFoundation\Response;
 
 class DashboardRootControllerTest extends WebTestCase
 {
@@ -17,7 +18,7 @@ public function testIndex(): void
 
         $client->request('GET', '/');
 
-        $this->assertResponseStatusCodeSame(200);
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
 
         $this->assertAnySelectorTextSame('#total_packages .display-6', '1');
     }
@@ -29,7 +30,7 @@ public function testCredits(): void
 
         $client->request('GET', '/credits');
 
-        $this->assertResponseStatusCodeSame(200);
+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
 
         $this->assertAnySelectorTextSame('.list-group-item div', 'v' . Kernel::VERSION);
     }