Merged
Conversation
2ac1359 to
e254a4a
Compare
e254a4a to
aa39f5c
Compare
codedmonkey
added a commit
that referenced
this pull request
Feb 27, 2025
codedmonkey
added a commit
that referenced
this pull request
Feb 28, 2025
codedmonkey
added a commit
that referenced
this pull request
Mar 9, 2025
codedmonkey
added a commit
that referenced
this pull request
Mar 9, 2025
codedmonkey
added a commit
that referenced
this pull request
Mar 9, 2025
Fix dependency regression introduced in #1 due to Testcontainers dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for the standalone image to the project using Testcontainers.
Note that v1.0.0 of
testcontainers/testcontainerscurrently does not supportsymfony/options-resolver:^7.0, see beluga-php/docker-php#86, this has to be fixed incomposer.jsononce that issue has been resolved.There are 2 pull requests numbered 1 in the source code, for the original one, see codedmonkey/conductor#1