Skip to content

Commit d704891

Browse files
committed
PR review changes
1 parent 0ac63a8 commit d704891

2 files changed

Lines changed: 12 additions & 6 deletions

File tree

src/app/theme/layout/admin/admin.component.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@ export class AdminComponent {
3030

3131
// public method
3232
navMobClick() {
33+
if (this.navCollapsedMob && !document.querySelector('app-navigation.pcoded-navbar').classList.contains('mob-open')) {
34+
document.querySelector('app-navigation.pcoded-navbar').classList.add('mob-open');
35+
} else {
36+
document.querySelector('app-navigation.pcoded-navbar').classList.remove('mob-open');
37+
}
3338
this.navCollapsedMob = !this.navCollapsedMob;
3439
}
3540

@@ -42,6 +47,7 @@ export class AdminComponent {
4247

4348
@HostListener('document:closeMobMenu')
4449
closeMenu() {
50+
document.querySelector('app-navigation.pcoded-navbar').classList.remove('mob-open');
4551
this.navCollapsedMob = false;
4652
}
4753
}

src/app/theme/layout/admin/nav-bar/nav-bar.component.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// angular import
2-
import { Component, HostListener, input, output } from '@angular/core';
2+
import { Component, EventEmitter, HostListener, Input, Output } from '@angular/core';
33
import { RouterModule } from '@angular/router';
44
import { CommonModule } from '@angular/common';
55

@@ -16,8 +16,8 @@ import { NavRightComponent } from './nav-right/nav-right.component';
1616
})
1717
export class NavBarComponent {
1818
// public props
19-
readonly NavCollapsedMob = output();
20-
navCollapsedMob = input<boolean>(false);
19+
@Output() readonly NavCollapsedMob = new EventEmitter<boolean>();
20+
@Input() navCollapsedMob = false;
2121
headerStyle: string;
2222
menuClass: boolean;
2323
collapseStyle: string;
@@ -44,9 +44,9 @@ export class NavBarComponent {
4444
}
4545

4646
closeMenu() {
47-
if (document.querySelector('app-navigation.pcoded-navbar').classList.contains('mob-open')) {
48-
document.dispatchEvent(new Event('closeMobMenu'));
49-
}
47+
// this.menuClass = false;
48+
// this.headerStyle = '';
49+
// this.collapseStyle = 'none';
5050
}
5151

5252
@HostListener('document:click', ['$event'])

0 commit comments

Comments
 (0)