Skip to content

⚡️ Speed up method Time.validate by 28% #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up method Time.validate by 28% #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/bokeh/core/property/datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
from __future__ import annotations

import logging # isort:skip
from bokeh.core.property.bases import Init, Property
from bokeh.core.property.singletons import Undefined

log = logging.getLogger(__name__)

#-----------------------------------------------------------------------------
Expand Down Expand Up @@ -133,14 +136,14 @@ def __init__(self, default: Init[str | datetime.time] = Undefined, *, help: str
super().__init__(default=default, help=help)

def validate(self, value: Any, detail: bool = True) -> None:
super().validate(value, detail)

if isinstance(value, datetime.time):
return

if isinstance(value, str):
fromisoformat = datetime.time.fromisoformat
try:
datetime.time.fromisoformat(value)
fromisoformat(value)
return
except ValueError:
pass
Expand Down