Skip to content

⚡️ Speed up function contains_tex_string by 88% #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up function contains_tex_string by 88% #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/bokeh/embed/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,14 @@
from ..core.types import ID
from ..document.document import DocJson

_dollars = r"\$\$.*?\$\$"

_braces = r"\\\[.*?\\\]"

_parens = r"\\\(.*?\\\)"

_tex_pattern = re.compile(f"{_dollars}|{_braces}|{_parens}", flags=re.S)

#-----------------------------------------------------------------------------
# Globals and constants
#-----------------------------------------------------------------------------
Expand Down Expand Up @@ -367,19 +375,13 @@ def is_tex_string(text: str) -> bool:
return pat.match(text) is not None

def contains_tex_string(text: str) -> bool:
''' Whether a string contains any pair of MathJax default delimiters
""" Whether a string contains any pair of MathJax default delimiters
Args:
text (str): String to check
Returns:
bool: True if string contains delimiters, False if not
'''
# these are non-greedy
dollars = r"\$\$.*?\$\$"
braces = r"\\\[.*?\\\]"
parens = r"\\\(.*?\\\)"

pat = re.compile(f"{dollars}|{braces}|{parens}", flags=re.S)
return pat.search(text) is not None
"""
return _tex_pattern.search(text) is not None

#-----------------------------------------------------------------------------
# Private API
Expand Down